SPARK-1703 Warn users if Spark is run on JRE6 but compiled with JDK7. #627
Conversation
This add some guards and good warning messages if users hit this issue.
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
bin/spark-class
Outdated
There was a problem hiding this comment.
can we go with lower case variable names for "local" variables?
There was a problem hiding this comment.
I also like that style, but this class uses the other style (always uses all-caps) pervasively. I can change it though, will just become inconsistent.
|
Two very minor comments, otherwise LGTM. |
|
Merged build triggered. |
|
Merged build started. |
|
@aarondav addressed your comments. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
LGTM. Merge at will. |
|
Thanks, merged. |
This add some guards and good warning messages if users hit this issue. /cc @aarondav with whom I discussed parts of the design. Author: Patrick Wendell <[email protected]> Closes #627 from pwendell/jdk6 and squashes the following commits: a38a958 [Patrick Wendell] Code review feedback 94e9f84 [Patrick Wendell] SPARK-1703 Warn users if Spark is run on JRE6 but compiled with JDK7. (cherry picked from commit 0c98a8f) Signed-off-by: Patrick Wendell <[email protected]>
There was a problem hiding this comment.
I realize this is already merged, but it looks like the jar error check is only tested on the assembly jar (not on the deps assembly jar). It might be good to check it in both cases.
This add some guards and good warning messages if users hit this issue. /cc @aarondav with whom I discussed parts of the design. Author: Patrick Wendell <[email protected]> Closes apache#627 from pwendell/jdk6 and squashes the following commits: a38a958 [Patrick Wendell] Code review feedback 94e9f84 [Patrick Wendell] SPARK-1703 Warn users if Spark is run on JRE6 but compiled with JDK7.
5 participants
This add some guards and good warning messages if users hit this issue. /cc @aarondav with whom I discussed parts of the design.