Skip to content

Conversation

@selvinsource
Copy link
Contributor

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@selvinsource
Copy link
Contributor Author

The contribution is my original work and I license the work to the project under the project's open source license.

@mengxr
Copy link
Contributor

mengxr commented May 17, 2015

@selvinsource Could you update the PR title use this format: [SPARK-7272] [MLLIB]...., and make the description more accurate? For example, this should be [SPARK-7272] [MLLIB] User guide for PMML model export. Thanks!

@selvinsource selvinsource changed the title Mllib pmml model export spark 7272 [SPARK-7272] [MLLIB] User guide for PMML model export May 17, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "PMML export = " + or change it to `PMML Model:\n". It is hard to think of a use case that mixes some strings with the XML content in the same line.

asfgit pushed a commit that referenced this pull request May 18, 2015
https://issues.apache.org/jira/browse/SPARK-7272

Author: Vincenzo Selvaggio <[email protected]>

Closes #6219 from selvinsource/mllib_pmml_model_export_SPARK-7272 and squashes the following commits:

c866fb8 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
1beda98 [Vincenzo Selvaggio] [SPARK-7272] Initial user guide for pmml export
d670662 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
2731375 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
680dc33 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
2e298b5 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
a932f51 [Vincenzo Selvaggio] Create mllib-pmml-model-export.md

(cherry picked from commit 814b3da)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in 814b3da May 18, 2015
@mengxr
Copy link
Contributor

mengxr commented May 18, 2015

LGTM. Merged into master and branch-1.4. Thanks! Btw, we may need to reorganize the layout. The current TOC of the user guide is really long.

@selvinsource
Copy link
Contributor Author

Great!

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
https://issues.apache.org/jira/browse/SPARK-7272

Author: Vincenzo Selvaggio <[email protected]>

Closes apache#6219 from selvinsource/mllib_pmml_model_export_SPARK-7272 and squashes the following commits:

c866fb8 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
1beda98 [Vincenzo Selvaggio] [SPARK-7272] Initial user guide for pmml export
d670662 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
2731375 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
680dc33 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
2e298b5 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
a932f51 [Vincenzo Selvaggio] Create mllib-pmml-model-export.md
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
https://issues.apache.org/jira/browse/SPARK-7272

Author: Vincenzo Selvaggio <[email protected]>

Closes apache#6219 from selvinsource/mllib_pmml_model_export_SPARK-7272 and squashes the following commits:

c866fb8 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
1beda98 [Vincenzo Selvaggio] [SPARK-7272] Initial user guide for pmml export
d670662 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
2731375 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
680dc33 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
2e298b5 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
a932f51 [Vincenzo Selvaggio] Create mllib-pmml-model-export.md
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
https://issues.apache.org/jira/browse/SPARK-7272

Author: Vincenzo Selvaggio <[email protected]>

Closes apache#6219 from selvinsource/mllib_pmml_model_export_SPARK-7272 and squashes the following commits:

c866fb8 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
1beda98 [Vincenzo Selvaggio] [SPARK-7272] Initial user guide for pmml export
d670662 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
2731375 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
680dc33 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
2e298b5 [Vincenzo Selvaggio] Update mllib-pmml-model-export.md
a932f51 [Vincenzo Selvaggio] Create mllib-pmml-model-export.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants