Skip to content

[SPARK-7488][ML] Feature Parity in PySpark for ml.recommendation #6015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[SPARK-7488][ML] Feature Parity in PySpark for ml.recommendation #6015

wants to merge 5 commits into from

Conversation

@brkyvz
Copy link
Contributor

@brkyvz brkyvz commented May 8, 2015

Adds Python Api for ALS under ml.recommendation in PySpark. Also adds seed as a settable parameter in the Scala Implementation of ALS.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 8, 2015

Test build #32256 has started for PR 6015 at commit eaed879.

@SparkQA
Copy link

SparkQA commented May 8, 2015

Test build #32256 has finished for PR 6015 at commit eaed879.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class EnumUtil
    • class Binarizer(JavaTransformer, HasInputCol, HasOutputCol):
    • class IDF(JavaEstimator, HasInputCol, HasOutputCol):
    • class IDFModel(JavaModel):
    • class Normalizer(JavaTransformer, HasInputCol, HasOutputCol):
    • class OneHotEncoder(JavaTransformer, HasInputCol, HasOutputCol):
    • class PolynomialExpansion(JavaTransformer, HasInputCol, HasOutputCol):
    • class RegexTokenizer(JavaTransformer, HasInputCol, HasOutputCol):
    • class StandardScaler(JavaEstimator, HasInputCol, HasOutputCol):
    • class StandardScalerModel(JavaModel):
    • class StringIndexer(JavaEstimator, HasInputCol, HasOutputCol):
    • class StringIndexerModel(JavaModel):
    • class Tokenizer(JavaTransformer, HasInputCol, HasOutputCol):
    • class VectorIndexer(JavaEstimator, HasInputCol, HasOutputCol):
    • class Word2Vec(JavaEstimator, HasStepSize, HasMaxIter, HasSeed, HasInputCol, HasOutputCol):
    • class Word2VecModel(JavaModel):
    • class HasCheckpointInterval(Params):
    • class HasSeed(Params):
    • class HasTol(Params):
    • class HasStepSize(Params):
    • class ALS(JavaEstimator, HasCheckpointInterval, HasMaxIter, HasPredictionCol, HasRegParam, HasSeed):
    • class ALSModel(JavaModel):
    • case class CreateTableAsSelect(

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32256/
Test PASSed.

mengxr
mengxr reviewed May 8, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
Copy link
Contributor

@mengxr mengxr May 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing setter for seed in ALS.

@mengxr
Copy link
Contributor

mengxr commented May 8, 2015

LGTM except minor inline comments.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2015

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32270/
Test FAILed.

@mengxr
Copy link
Contributor

mengxr commented May 8, 2015

test this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 8, 2015

Test build #32276 has started for PR 6015 at commit be6e931.

@SparkQA
Copy link

SparkQA commented May 8, 2015

Test build #32276 has finished for PR 6015 at commit be6e931.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class HasCheckpointInterval(Params):
    • class ALS(JavaEstimator, HasCheckpointInterval, HasMaxIter, HasPredictionCol, HasRegParam, HasSeed):
    • class ALSModel(JavaModel):

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 8, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32276/
Test PASSed.

asfgit pushed a commit that referenced this pull request May 9, 2015
@brkyvz @mengxr
[SPARK-7488] [ML] Feature Parity in PySpark for ml.recommendation
85cab34 
Adds Python Api for `ALS` under `ml.recommendation` in PySpark. Also adds seed as a settable parameter in the Scala Implementation of ALS.

Author: Burak Yavuz <[email protected]>

Closes #6015 from brkyvz/ml-rec and squashes the following commits:

be6e931 [Burak Yavuz] addressed comments
eaed879 [Burak Yavuz] readd numFeatures
0bd66b1 [Burak Yavuz] fixed seed
7f6d964 [Burak Yavuz] merged master
52e2bda [Burak Yavuz] added ALS

(cherry picked from commit 84bf931)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in 84bf931 May 9, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@brkyvz @jeanlyn
[SPARK-7488] [ML] Feature Parity in PySpark for ml.recommendation
34be542 
Adds Python Api for `ALS` under `ml.recommendation` in PySpark. Also adds seed as a settable parameter in the Scala Implementation of ALS.

Author: Burak Yavuz <[email protected]>

Closes apache#6015 from brkyvz/ml-rec and squashes the following commits:

be6e931 [Burak Yavuz] addressed comments
eaed879 [Burak Yavuz] readd numFeatures
0bd66b1 [Burak Yavuz] fixed seed
7f6d964 [Burak Yavuz] merged master
52e2bda [Burak Yavuz] added ALS
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@brkyvz @jeanlyn
[SPARK-7488] [ML] Feature Parity in PySpark for ml.recommendation
6197178 
Adds Python Api for `ALS` under `ml.recommendation` in PySpark. Also adds seed as a settable parameter in the Scala Implementation of ALS.

Author: Burak Yavuz <[email protected]>

Closes apache#6015 from brkyvz/ml-rec and squashes the following commits:

be6e931 [Burak Yavuz] addressed comments
eaed879 [Burak Yavuz] readd numFeatures
0bd66b1 [Burak Yavuz] fixed seed
7f6d964 [Burak Yavuz] merged master
52e2bda [Burak Yavuz] added ALS
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@brkyvz @nemccarthy
[SPARK-7488] [ML] Feature Parity in PySpark for ml.recommendation
6675e10 
Adds Python Api for `ALS` under `ml.recommendation` in PySpark. Also adds seed as a settable parameter in the Scala Implementation of ALS.

Author: Burak Yavuz <[email protected]>

Closes apache#6015 from brkyvz/ml-rec and squashes the following commits:

be6e931 [Burak Yavuz] addressed comments
eaed879 [Burak Yavuz] readd numFeatures
0bd66b1 [Burak Yavuz] fixed seed
7f6d964 [Burak Yavuz] merged master
52e2bda [Burak Yavuz] added ALS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brkyvz @AmplabJenkins @SparkQA @mengxr