Skip to content

[SPARK-2155][SQL] add CaseKeyWhen for "CASE a WHEN b THEN c [WHEN d THEN e]* [ELSE f] END" #5979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-2155][SQL] add CaseKeyWhen for "CASE a WHEN b THEN c [WHEN d THEN e]* [ELSE f] END" #5979

wants to merge 1 commit into from

Conversation

@cloud-fan
Copy link
Contributor

@cloud-fan cloud-fan commented May 7, 2015

Avoid translating to CaseWhen and evaluate the key expression many times.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32109 has started for PR 5979 at commit 3ce54e1.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32109 has finished for PR 5979 at commit 3ce54e1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • sealed trait LDAOptimizer
    • final class EMLDAOptimizer extends LDAOptimizer
    • final class OnlineLDAOptimizer extends LDAOptimizer
    • trait CaseWhenLike extends Expression
    • case class CaseWhen(branches: Seq[Expression]) extends CaseWhenLike
    • case class CaseKeyWhen(key: Expression, branches: Seq[Expression]) extends CaseWhenLike

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32109/
Test PASSed.

asfgit pushed a commit that referenced this pull request May 7, 2015
@cloud-fan @marmbrus
[SPARK-2155] [SQL] [WHEN D THEN E] [ELSE F] add CaseKeyWhen for "CASE…
622a0c5 
… a WHEN b THEN c * END"

Avoid translating to CaseWhen and evaluate the key expression many times.

Author: Wenchen Fan <[email protected]>

Closes #5979 from cloud-fan/condition and squashes the following commits:

3ce54e1 [Wenchen Fan] add CaseKeyWhen

(cherry picked from commit 35f0173)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in 35f0173 May 7, 2015
@marmbrus
Copy link
Contributor

marmbrus commented May 7, 2015

Thanks! Merged to master and 1.4.

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@cloud-fan @jeanlyn
[SPARK-2155] [SQL] [WHEN D THEN E] [ELSE F] add CaseKeyWhen for "CASE…
2225e04 
… a WHEN b THEN c * END"

Avoid translating to CaseWhen and evaluate the key expression many times.

Author: Wenchen Fan <[email protected]>

Closes apache#5979 from cloud-fan/condition and squashes the following commits:

3ce54e1 [Wenchen Fan] add CaseKeyWhen
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@cloud-fan @jeanlyn
[SPARK-2155] [SQL] [WHEN D THEN E] [ELSE F] add CaseKeyWhen for "CASE…
9e3b8ab 
… a WHEN b THEN c * END"

Avoid translating to CaseWhen and evaluate the key expression many times.

Author: Wenchen Fan <[email protected]>

Closes apache#5979 from cloud-fan/condition and squashes the following commits:

3ce54e1 [Wenchen Fan] add CaseKeyWhen
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@cloud-fan @nemccarthy
[SPARK-2155] [SQL] [WHEN D THEN E] [ELSE F] add CaseKeyWhen for "CASE…
dc69ced 
… a WHEN b THEN c * END"

Avoid translating to CaseWhen and evaluate the key expression many times.

Author: Wenchen Fan <[email protected]>

Closes apache#5979 from cloud-fan/condition and squashes the following commits:

3ce54e1 [Wenchen Fan] add CaseKeyWhen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cloud-fan @AmplabJenkins @SparkQA @marmbrus