Skip to content

[SPARK-7153][SQL] support all integral type ordinal in GetArrayItem #5706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cloud-fan wants to merge 1 commit into from
Closed

[SPARK-7153][SQL] support all integral type ordinal in GetArrayItem #5706

cloud-fan wants to merge 1 commit into from

Conversation

@cloud-fan
Copy link
Contributor

@cloud-fan cloud-fan commented Apr 26, 2015

first convert ordinal to Number, then convert to int type.

@cloud-fan
Copy link
Contributor Author

cloud-fan commented Apr 26, 2015

Jenkins test it please.

@cloud-fan
Copy link
Contributor Author

cloud-fan commented Apr 27, 2015

Hi @rxin , how can I trigger the jenkins to run test?

@rxin
Copy link
Contributor

rxin commented Apr 27, 2015

Jenkins, test this please.

@rxin
Copy link
Contributor

rxin commented Apr 27, 2015

(I think you need permission from us to do it)

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 27, 2015

Can one of the admins verify this patch?

@cloud-fan
Copy link
Contributor Author

cloud-fan commented Apr 28, 2015

Seems Jenkins got a problem...

@cloud-fan cloud-fan changed the title [SPARK-7153][SQL] support long type ordinal in GetItem [SPARK-7153][SQL] support long type ordinal in GetArrayItem May 12, 2015
@cloud-fan
Copy link
Contributor Author

cloud-fan commented May 12, 2015

test this please.

@cloud-fan cloud-fan changed the title [SPARK-7153][SQL] support long type ordinal in GetArrayItem [SPARK-7153][SQL] support all integral type ordinal in GetArrayItem Jun 19, 2015
@cloud-fan
Copy link
Contributor Author

cloud-fan commented Jun 19, 2015

As we have moved out all ExtractValue(GetField) stuff from complexType.scala, we should rename it.

@cloud-fan
Copy link
Contributor Author

cloud-fan commented Jun 19, 2015

cc @marmbrus , it's a minor change.

@marmbrus
Copy link
Contributor

marmbrus commented Jun 19, 2015

ok to test

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 19, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 19, 2015

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 19, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 21, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 21, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented Jun 21, 2015

Test build #35384 has started for PR 5706 at commit 915db79.

@SparkQA
Copy link

SparkQA commented Jun 21, 2015

Test build #35384 has finished for PR 5706 at commit 915db79.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 21, 2015

Merged build finished. Test FAILed.

@cloud-fan
Copy link
Contributor Author

cloud-fan commented Jun 21, 2015

retest this please.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 21, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 21, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented Jun 21, 2015

Test build #35393 has started for PR 5706 at commit 915db79.

@SparkQA
Copy link

SparkQA commented Jun 21, 2015

Test build #35393 has finished for PR 5706 at commit 915db79.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 21, 2015

Merged build finished. Test PASSed.

@marmbrus
Copy link
Contributor

marmbrus commented Jun 23, 2015

Thanks! Merging to master.

@asfgit asfgit closed this in 860a49e Jun 23, 2015
animeshbaranawal pushed a commit to animeshbaranawal/spark that referenced this pull request Jun 25, 2015
@cloud-fan
[SPARK-7153] [SQL] support all integral type ordinal in GetArrayItem
29fc90e 
first convert `ordinal` to `Number`, then convert to int type.

Author: Wenchen Fan <[email protected]>

Closes apache#5706 from cloud-fan/7153 and squashes the following commits:

915db79 [Wenchen Fan] fix 7153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cloud-fan @rxin @AmplabJenkins @marmbrus @SparkQA