Skip to content

[SPARK-7033][SPARKR] Clean usage of split. Use partition instead where applicable. #5628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sun-rui wants to merge 2 commits into from
Closed

[SPARK-7033][SPARKR] Clean usage of split. Use partition instead where applicable. #5628

sun-rui wants to merge 2 commits into from

Conversation

@sun-rui
Copy link
Contributor

@sun-rui sun-rui commented Apr 22, 2015

No description provided.

@shivaram
Copy link
Contributor

shivaram commented Apr 23, 2015

Jenkins, ok to test

@shivaram
Copy link
Contributor

shivaram commented Apr 23, 2015

@concretevitamin could you take a look at this ?

@SparkQA
Copy link

SparkQA commented Apr 23, 2015

Test build #30793 has finished for PR 5628 at commit d531c86.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@concretevitamin
Copy link
Contributor

concretevitamin commented Apr 23, 2015

Thanks, @sun-rui - doing a grep, could you also update test_rdd.R's line 124?

@sun-rui
Copy link
Contributor Author

sun-rui commented Apr 24, 2015

@shivaram , yeah, I forgot to do cleanup in tests. Now the tests are cleaned. please check it.

@concretevitamin
Copy link
Contributor

concretevitamin commented Apr 24, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Apr 24, 2015

Test build #30899 has finished for PR 5628 at commit 046bc9e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@shivaram
Copy link
Contributor

shivaram commented Apr 24, 2015

Thanks @sun-rui . Merging this

@asfgit asfgit closed this in ebb77b2 Apr 24, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 14, 2015
[SPARK-7033] [SPARKR] Clean usage of split. Use partition instead whe…
9fe48b3 
…re applicable.

Author: Sun Rui <[email protected]>

Closes apache#5628 from sun-rui/SPARK-7033 and squashes the following commits:

046bc9e [Sun Rui] Clean split usage in tests.
d531c86 [Sun Rui] [SPARK-7033][SPARKR] Clean usage of split. Use partition instead where applicable.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@nemccarthy
[SPARK-7033] [SPARKR] Clean usage of split. Use partition instead whe…
86e8a5e 
…re applicable.

Author: Sun Rui <[email protected]>

Closes apache#5628 from sun-rui/SPARK-7033 and squashes the following commits:

046bc9e [Sun Rui] Clean split usage in tests.
d531c86 [Sun Rui] [SPARK-7033][SPARKR] Clean usage of split. Use partition instead where applicable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sun-rui @shivaram @SparkQA @concretevitamin