[SPARK-6997][SQL] Convert StringType in LocalTableScan #5579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
i will add a test for this |
|
Test build #30558 has finished for PR 5579 at commit
|
scwf
force-pushed
the
fix-localtablescan
branch
from
dcf5b9d to
3fd9e5f
Compare
|
Test build #30561 has finished for PR 5579 at commit
|
Contributor
Author
|
Seems this is not nessarry since we have convert the data from scala objects to catalyst rows / types when construct LocalRelation. I am closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up for #5350, we should convert string of LocalTableScan to UTF8String