Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Apr 17, 2015

As a follow up PR to #5544.

cc @davies

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Python, it's called bool

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type for boolean is bool:

>>> type(True)
<type 'bool'>
>>> type(1)
<type 'int'>

Similar to int for integer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird to see we put boolean and int together, it should be either boolean/integer or bool/int.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I removed int, since 1, 0 has the same value as True, False anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also change the tests in doc string to use True and False?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then that's different from the Pandas examples?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, no perfect.

@SparkQA
Copy link

SparkQA commented Apr 17, 2015

Test build #30488 has finished for PR 5558 at commit d2dcf24.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@SparkQA
Copy link

SparkQA commented Apr 17, 2015

Test build #30498 has finished for PR 5558 at commit f4c276f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@davies
Copy link
Contributor

davies commented Apr 17, 2015

LGTM.

@asfgit asfgit closed this in a452c59 Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants