Skip to content

[MLlib] [SPARK-6713] Iterators in columnSimilarities for mapPartitionsWithIndex #5364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[MLlib] [SPARK-6713] Iterators in columnSimilarities for mapPartitionsWithIndex #5364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,6 @@ class RowMatrix(
val rand = new XORShiftRandom(indx)
val scaled = new Array[Double](p.size)
iter.flatMap { row =>
val buf = new ListBuffer[((Int, Int), Double)]()
row match {
case SparseVector(size, indices, values) =>
val nnz = indices.size
Expand All @@ -540,8 +539,9 @@ class RowMatrix(
scaled(k) = values(k) / q(indices(k))
k += 1
}
k = 0
while (k < nnz) {

Iterator.tabulate (nnz) { k =>
val buf = new ListBuffer[((Int, Int), Double)]()
val i = indices(k)
val iVal = scaled(k)
if (iVal != 0 && rand.nextDouble() < p(i)) {
Expand All @@ -555,17 +555,17 @@ class RowMatrix(
l += 1
}
}
k += 1
}
buf
}.flatten
case DenseVector(values) =>
val n = values.size
var i = 0
while (i < n) {
scaled(i) = values(i) / q(i)
i += 1
}
i = 0
while (i < n) {
Iterator.tabulate (n) { i =>
val buf = new ListBuffer[((Int, Int), Double)]()
val iVal = scaled(i)
if (iVal != 0 && rand.nextDouble() < p(i)) {
var j = i + 1
Expand All @@ -577,10 +577,9 @@ class RowMatrix(
j += 1
}
}
i += 1
}
buf
}.flatten
}
buf
}
}.reduceByKey(_ + _).map { case ((i, j), sim) =>
MatrixEntry(i.toLong, j.toLong, sim)
Expand Down