[SPARK-52837][PYTHON][FOLLOWUP] Add versionadded to TimeType doc
#53436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @dengziming and @zhengruifeng from the original PR |
zhengruifeng
approved these changes
Dec 11, 2025
Member
Author
|
Thank you, @zhengruifeng ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Dec 11, 2025
### What changes were proposed in this pull request? This PR aims to add `versionadded` to `TimeType`. ### Why are the changes needed? For `Scala/Java` documentation, we have `since` information. https://github.com/apache/spark/blob/22e26598785e11303409f43fc08ce627053dadb4/sql/api/src/main/scala/org/apache/spark/sql/types/TimeType.scala#L31-L34 We had better provide a correct information for the newly added `TimeType` in Python documentation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53436 from dongjoon-hyun/SPARK-52837. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit d80a0f3) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Merged to master/4.1 for Apache Spark 4.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
versionaddedtoTimeType.Why are the changes needed?
For
Scala/Javadocumentation, we have@sinceinformation.spark/sql/api/src/main/scala/org/apache/spark/sql/types/TimeType.scala
Lines 31 to 34 in 22e2659
We had better provide a correct information for the newly added
TimeTypein Python documentation.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.