[SPARK-54584][SS] Adding .name() to DataStreamReader to enable naming streaming sources
#53309
+443
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericm-db
changed the title
.name() to DataStreamReader to enable naming streaming sources.name() to DataStreamReader to enable naming streaming sources
HyukjinKwon
changed the title
.name() to DataStreamReader to enable naming streaming sources.name() to DataStreamReader to enable naming streaming sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We want to add
.name()to the DataStreamReader to enable naming streaming sources, which will allow users to add, remove and reorder sources. This API is currently package-private and not user-accessible.Why are the changes needed?
Currently, if a user tries to make any change to their streaming source in their query, the query will fail as the way we compare sources (via ordinal in the logical plan) are incompatible. Keying by name as opposed to ordinal is far less brittle
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No