[SPARK-6673] spark-shell.cmd can't start in Windows even when spark was built

[tsudukim]

added equivalent script to load-spark-env.sh

[SparkQA]

Test build #29593 has started for PR 5328 at commit aaefb19.

[SparkQA]

Test build #29593 has finished for PR 5328 at commit aaefb19.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • case class Literal protected (value: Any, dataType: DataType) extends LeafExpression
• This patch does not change any dependencies.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29593/
Test PASSed.

[srowen]

CC @vanzin; I tend to trust your judgment about this and it does seem like Windows should have the same script. Does this only affect master / 1.4?

[tsudukim]

This problem is introduced by e3eb393
https://issues.apache.org/jira/browse/SPARK-6406
So this seems to affect only master branch.

[vanzin]

Ah, I see that #5085 broke this in master. The previous code detected the scala version automatically, although in a different way from this patch. I tend to prefer the code that was there before (simpler), but don't have strong feelings either way.

[srowen]

@tsudukim up to you on whether you want to merge this or a different version. I'll merge whatever you see fit tomorrow since this one's important to fix.

[pwendell]

@srowen @andrewor14 @vanzin - if this was caused by #5085, then does it affect Spark 1.3?

[srowen]

Agree, I think this is only for master, but wanted to check with @andrewor14 just because it was marked as a blocker for 1.3.1 / 1.4.0. I think it's OK to merge and then if for some reason it needs to go back into 1.3.1 we can do that.

[pwendell]

Okay - let's see if we can figure that out and hopefully update the affects and target version on the JIRA to be clear this is unrelated to 1.3.

[tsudukim]

@srowen This version is OK to merge.