[SPARK-54355][CONNECT] Make spark.connect.session.planCompression.defaultAlgorithm to support NONE
#53068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…faultAlgorithm` to support `NONE`
Member
Author
|
Could you review this PR, please, @xi-db and @hvanhovell ? |
Member
Author
|
Could you review this when you have some time, @sryza ? |
Member
Author
|
Could you review this, @dtenedor ? |
Member
Author
|
Could you review this when you have some time, @cloud-fan ? |
Member
Author
|
Could you review this, @gengliangwang ? |
Member
|
@dongjoon-hyun I’m not familiar with the related changes, so I’ll defer to other committers. |
Member
Author
|
No problem. Thank you for spending your time here, @gengliangwang . |
sarutak
approved these changes
Nov 15, 2025
Member
sarutak
left a comment
sarutak
left a comment
There was a problem hiding this comment.
I confirmed this works and NONE seems consistent with other similar configs.
Member
Author
|
Thank you so much, @sarutak . Merged to master/4.1 for Apache Spark 4.1.0 to provide a way to escape when we hit a regression . |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 15, 2025
…faultAlgorithm` to support `NONE` ### What changes were proposed in this pull request? This PR aims to make `spark.connect.session.planCompression.defaultAlgorithm` to support `NONE` additionally. ### Why are the changes needed? **BEFORE** ``` $ bin/spark-connect-shell -c spark.connect.session.planCompression.defaultAlgorithm=NONE ... $ scala> spark.range(1).count() ... Caused by: org.apache.spark.SparkIllegalArgumentException: [INVALID_CONF_VALUE.OUT_OF_RANGE_OF_OPTIONS] The value 'NONE' in the config "spark.connect.session.planCompression.defaultAlgorithm" is invalid. It should be one of 'ZSTD'. SQLSTATE: 22022 ``` **AFTER** ``` $ bin/spark-connect-shell -c spark.connect.session.planCompression.defaultAlgorithm=NONE ... scala> spark.range(1).count() val res0: Long = 1 ``` ### Does this PR introduce _any_ user-facing change? No behavior change because this is a new option for a new feature. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53068 from dongjoon-hyun/SPARK-54355. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit e3e9863) Signed-off-by: Dongjoon Hyun <[email protected]>
Contributor
|
Thanks @dongjoon-hyun for the PR! Late LGTM |
Member
Author
|
Thank you, @xi-db ! |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…faultAlgorithm` to support `NONE` ### What changes were proposed in this pull request? This PR aims to make `spark.connect.session.planCompression.defaultAlgorithm` to support `NONE` additionally. ### Why are the changes needed? **BEFORE** ``` $ bin/spark-connect-shell -c spark.connect.session.planCompression.defaultAlgorithm=NONE ... $ scala> spark.range(1).count() ... Caused by: org.apache.spark.SparkIllegalArgumentException: [INVALID_CONF_VALUE.OUT_OF_RANGE_OF_OPTIONS] The value 'NONE' in the config "spark.connect.session.planCompression.defaultAlgorithm" is invalid. It should be one of 'ZSTD'. SQLSTATE: 22022 ``` **AFTER** ``` $ bin/spark-connect-shell -c spark.connect.session.planCompression.defaultAlgorithm=NONE ... scala> spark.range(1).count() val res0: Long = 1 ``` ### Does this PR introduce _any_ user-facing change? No behavior change because this is a new option for a new feature. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#53068 from dongjoon-hyun/SPARK-54355. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to make
spark.connect.session.planCompression.defaultAlgorithmto supportNONEadditionally.Why are the changes needed?
BEFORE
AFTER
Does this PR introduce any user-facing change?
No behavior change because this is a new option for a new feature.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.