[SPARK-54127][BUILD] Fix sbt inconsistent shading package #52825
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
approved these changes
Nov 3, 2025
|
Which version should we start with to fix this issue? branch-4.0 or branch-3.5? @pan3793 |
|
@LuciferYang the inconsistency exists since the SPARK-40448 (3.4.0), so it also applicable to branch-3.5. But as mentioned in the PR description
backport is optional |
dongjoon-hyun
approved these changes
Nov 3, 2025
There was a problem hiding this comment.
+1, LGTM. Thank you, @pan3793 and @LuciferYang .
Merged to master/4.1 for Apache Spark 4.1.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 3, 2025
### What changes were proposed in this pull request? Fix sbt inconsistent shading package for `spark-connect` module ### Why are the changes needed? Take 4.1.0-preview3 as the example, which is built by Maven. ``` $ jar tf jars/spark-connect_2.13-4.1.0-preview3.jar | grep 'connect/grpc' | head org/sparkproject/connect/grpc/ org/sparkproject/connect/grpc/inprocess/ org/sparkproject/connect/grpc/inprocess/InProcessTransport$InProcessStream$InProcessServerStream.class org/sparkproject/connect/grpc/inprocess/InProcessTransport$2.class org/sparkproject/connect/grpc/inprocess/InProcessTransport$InProcessStream$InProcessClientStream.class org/sparkproject/connect/grpc/inprocess/InProcessTransport$SingleMessageProducer.class org/sparkproject/connect/grpc/inprocess/InProcessTransport$6.class org/sparkproject/connect/grpc/inprocess/InProcessTransport$1.class org/sparkproject/connect/grpc/inprocess/InProcessSocketAddress.class org/sparkproject/connect/grpc/inprocess/InProcessTransport$InProcessStream.class ``` the produced jar built by SBT has a different relocated package for grpc classes ``` $ jar tf jars/spark-connect_2.13-4.1.0-SNAPSHOT.jar | grep 'connect/grpc' | head org/sparkproject/connect/grpc/ org/sparkproject/connect/grpc/io/ org/sparkproject/connect/grpc/io/grpc/ org/sparkproject/connect/grpc/io/grpc/Attributes$1.class org/sparkproject/connect/grpc/io/grpc/Attributes$Builder.class org/sparkproject/connect/grpc/io/grpc/Attributes$Key.class org/sparkproject/connect/grpc/io/grpc/Attributes.class org/sparkproject/connect/grpc/io/grpc/BinaryLog.class org/sparkproject/connect/grpc/io/grpc/BindableService.class org/sparkproject/connect/grpc/io/grpc/CallCredentials$MetadataApplier.class ``` ### Does this PR introduce _any_ user-facing change? No, so far I don't see such inconsistent causes real issue. ### How was this patch tested? Verified the output of `dev/make-distribution.sh --sbt-enabled` ``` jar tf jars/spark-connect_2.13-4.1.0-SNAPSHOT.jar | grep 'connect/grpc' | head org/sparkproject/connect/grpc/ org/sparkproject/connect/grpc/Attributes$1.class org/sparkproject/connect/grpc/Attributes$Builder.class org/sparkproject/connect/grpc/Attributes$Key.class org/sparkproject/connect/grpc/Attributes.class org/sparkproject/connect/grpc/BinaryLog.class org/sparkproject/connect/grpc/BindableService.class org/sparkproject/connect/grpc/CallCredentials$MetadataApplier.class org/sparkproject/connect/grpc/CallCredentials$RequestInfo.class org/sparkproject/connect/grpc/CallCredentials.class ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52825 from pan3793/SPARK-54127. Authored-by: Cheng Pan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 3d92bdf) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Let's deliver this to Apache Spark 4.1.0 only for now. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix sbt inconsistent shading package for
spark-connectmoduleWhy are the changes needed?
Take 4.1.0-preview3 as the example, which is built by Maven.
the produced jar built by SBT has a different relocated package for grpc classes
Does this PR introduce any user-facing change?
No, so far I don't see such inconsistent causes real issue.
How was this patch tested?
Verified the output of
dev/make-distribution.sh --sbt-enabledWas this patch authored or co-authored using generative AI tooling?
No.