[SPARK-54088][CORE] When TaskSchedulerImpl searches for an executor to schedule an unschedulable task, it should exclude executors that are pending to remove #52793
+42
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o schedule an unschedulable task, it should exclude executors that are pending to remove
holdenk
reviewed
Oct 31, 2025
| // in turn is used to decide when we can attain data locality on a given host | ||
| protected val hostToExecutors = new HashMap[String, HashSet[String]] | ||
|
|
||
| protected val availableHostToExecutors = new HashMap[String, HashSet[String]] |
There was a problem hiding this comment.
maintain this for quick check
holdenk
reviewed
Oct 31, 2025
| // unschedulable tasks else we will abort immediately. | ||
| executorIdToRunningTaskIds.find(x => !isExecutorBusy(x._1)) match { | ||
| executorIdToRunningTaskIds.find( | ||
| x => isExecutorAvailable(x._1) && !isExecutorBusy(x._1)) match { |
There was a problem hiding this comment.
Could we just extend busy to include those we're planning on removing?
There was a problem hiding this comment.
IF we can directly use CoarseGrainedSchedulerBackend's executorPendingToRemove should be more better, but seems can't?
maheshk114
reviewed
Nov 1, 2025
| .filter { id => !executorsPendingToRemove.contains(id) } | ||
| .filter { id => force || !scheduler.isExecutorBusy(id) } | ||
| executorsToKill.foreach { id => executorsPendingToRemove(id) = !countFailures } | ||
| executorsToKill.foreach { id => { |
There was a problem hiding this comment.
what about decommissioned executors ?
|
|
||
| if (!launchedAnyTask) { | ||
| taskSet.getCompletelyExcludedTaskIfAny(hostToExecutors).foreach { taskIndex => | ||
| taskSet.getCompletelyExcludedTaskIfAny(availableHostToExecutors).foreach { taskIndex => |
There was a problem hiding this comment.
availableHostToExecutors or hostToAvailableExecutors
|
|
||
| if (!launchedAnyTask) { | ||
| taskSet.getCompletelyExcludedTaskIfAny(hostToExecutors).foreach { taskIndex => | ||
| taskSet.getCompletelyExcludedTaskIfAny(availableHostToExecutors).foreach { taskIndex => |
There was a problem hiding this comment.
I think it will be simpler to just have a hash set updated for killed executor and filter out from executorIdToHost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Call kill executor
executor 18 failed to be killed
causing TaskSchedulerImpl can't mark TaskSet as UnschedulableTaskSet then call a new container then causing task stuck
Why are the changes needed?
Avoiding task stuck
Does this PR introduce any user-facing change?
No
How was this patch tested?
MT
Was this patch authored or co-authored using generative AI tooling?
NO