[SPARK-53921][Geo][PYTHON][FOLLOWUP] Add GeographyType and GeometryType to __all__ in types
#52790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
commented
Oct 30, 2025
Contributor
Author
uros-db
left a comment
uros-db
left a comment
There was a problem hiding this comment.
@zhengruifeng Please review.
zhengruifeng
approved these changes
Oct 30, 2025
Contributor
|
thanks for the quick fix! |
Contributor
|
thanks, merged to master |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…pe to `__all__` in types ### What changes were proposed in this pull request? This PR follows up on apache#52627, and addresses a gap - `GeographyType` and `GeometryType` should be included in `__all__`. ### Why are the changes needed? Include geospatial types in __all__ for `types.py`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests suffice. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52790 from uros-db/geo-python-types-all. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR follows up on #52627, and addresses a gap -
GeographyTypeandGeometryTypeshould be included in__all__.Why are the changes needed?
Include geospatial types in all for
types.py.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests suffice.
Was this patch authored or co-authored using generative AI tooling?
No.