[SPARK-53921][Geo][PYTHON][FOLLOWUP] Fix invalid algorithm error for Geography JSON parsing #52772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
commented
Oct 28, 2025
Contributor
Author
uros-db
left a comment
uros-db
left a comment
There was a problem hiding this comment.
@zhengruifeng @HyukjinKwon Please review.
zhengruifeng
approved these changes
Oct 29, 2025
Contributor
|
merged to master |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…Geography JSON parsing ### What changes were proposed in this pull request? This PR follows up on apache#52627, and fixes an issue with `GeographyType` JSON parsing in PySpark. Also, this PR adds appropriate tests for JSON parsing, both for `GeographyType` and `GeometryType`. ### Why are the changes needed? Fixing a wrong error class thrown in the JSON parsing method for `GeographyType`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added new test cases to: - `pyspark.sql.tests.test_geographytype` - `pyspark.sql.tests.test_geometrytype` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52772 from uros-db/geo-python-types-tests. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR follows up on #52627, and fixes an issue with
GeographyTypeJSON parsing in PySpark. Also, this PR adds appropriate tests for JSON parsing, both forGeographyTypeandGeometryType.Why are the changes needed?
Fixing a wrong error class thrown in the JSON parsing method for
GeographyType.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added new test cases to:
pyspark.sql.tests.test_geographytypepyspark.sql.tests.test_geometrytypeWas this patch authored or co-authored using generative AI tooling?
No.