[SPARK-53914][BUILD][FOLLOWUP] Fix branch-4.0 daily maven test #52707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @LuciferYang |
sarutak
approved these changes
Oct 23, 2025
Member
sarutak
left a comment
sarutak
left a comment
There was a problem hiding this comment.
LGTM. This change doesn't affect GA on push so let me merge this and check the maven test work by triggering it manually.
Member
|
I triggered If it passes, other maven tests for |
Member
Author
|
@sarutak, thank you for merging and checking |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? I apologize for making a silly mistake. https://github.com/apache/spark/actions/runs/18718856740/job/53385398202 ``` [ERROR] Could not find the selected project in the reactor: sql/connect/client/jdbc [ERROR] Could not find the selected project in the reactor: sql/connect/client/jdbc -> [Help 1] ``` The issue is, ``` elif [[ "$MODULES_TO_TEST" == "connect" && "$INPUT_BRANCH" == "branch-4.0" ]]; then ... ``` should be defined before ``` elif [[ "$MODULES_TO_TEST" == "connect" ]]; then ... ``` ### Why are the changes needed? Fix branch-4.0 daily maven test ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Monitor daily Maven CI stability. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52707 from pan3793/SPARK-53914-followup. Authored-by: Cheng Pan <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I apologize for making a silly mistake.
https://github.com/apache/spark/actions/runs/18718856740/job/53385398202
The issue is,
should be defined before
Why are the changes needed?
Fix branch-4.0 daily maven test
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Monitor daily Maven CI stability.
Was this patch authored or co-authored using generative AI tooling?
No.