[SPARK-53973][Avro] Classify errors for AvroOptions boolean casting failure #52686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishshri-db
approved these changes
Oct 21, 2025
Contributor
|
Will merge once CI is green |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…ailure ### What changes were proposed in this pull request? When an option of AvroOptions requires boolean value, but a value that cannot be casted to boolean is passed in, classify the error. ### Why are the changes needed? The error should be classified to have better user experience. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added a unit test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52686 from siying/avro_boolean_option. Authored-by: Siying Dong <[email protected]> Signed-off-by: Anish Shrigondekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When an option of AvroOptions requires boolean value, but a value that cannot be casted to boolean is passed in, classify the error.
Why are the changes needed?
The error should be classified to have better user experience.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added a unit test.
Was this patch authored or co-authored using generative AI tooling?
No.