Skip to content

[SPARK-53958][BUILD] Simplify Jackson deps management by using BOM #52668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pan3793 wants to merge 3 commits into from
Closed

[SPARK-53958][BUILD] Simplify Jackson deps management by using BOM #52668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46c5d4b
[SPARK-53958][BUILD] Simplify Jackson deps management by using BOM
pan3793 Oct 20, 2025
d15ff1c
revert exclusion
pan3793 Oct 21, 2025
c6fd772
revert
pan3793 Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 4 additions & 23 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@
<scalafmt.validateOnly>true</scalafmt.validateOnly>
<scalafmt.changedOnly>true</scalafmt.changedOnly>
<fasterxml.jackson.version>2.19.2</fasterxml.jackson.version>
<fasterxml.jackson.databind.version>2.19.2</fasterxml.jackson.databind.version>
Copy link
Member Author

@pan3793 pan3793 Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case that jackson-databind has a standalone patched version, the jackson-bom also has a new release, for example

https://mvnrepository.com/artifact/com.fasterxml.jackson/jackson-bom/2.13.4.20221013

<ws.xmlschema.version>2.3.1</ws.xmlschema.version>
<snappy.version>1.1.10.8</snappy.version>
<netlib.ludovic.dev.version>3.0.4</netlib.ludovic.dev.version>
Expand Down Expand Up @@ -1063,29 +1062,11 @@
<version>${codahale.metrics.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>${fasterxml.jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${fasterxml.jackson.databind.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>${fasterxml.jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jsr310</artifactId>
<version>${fasterxml.jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.module</groupId>
<artifactId>jackson-module-scala_${scala.binary.version}</artifactId>
<groupId>com.fasterxml.jackson</groupId>
<artifactId>jackson-bom</artifactId>
<version>${fasterxml.jackson.version}</version>
<scope>import</scope>
<type>pom</type>
</dependency>
<dependency>
<groupId>org.apache.ws.xmlschema</groupId>
Expand Down
6 changes: 5 additions & 1 deletion project/SparkBuild.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import sbt.Classpaths.publishOrSkip
import sbt.Keys._
import sbt.librarymanagement.{ VersionNumber, SemanticSelector }
import com.etsy.sbt.checkstyle.CheckstylePlugin.autoImport._
import com.here.bom.Bom
import com.simplytyped.Antlr4Plugin._
import sbtpomreader.{PomBuild, SbtPomKeys}
import com.typesafe.tools.mima.plugin.MimaKeys
Expand Down Expand Up @@ -1096,8 +1097,11 @@ object KubernetesIntegrationTests {
*/
object DependencyOverrides {
lazy val guavaVersion = sys.props.get("guava.version").getOrElse("33.4.0-jre")
lazy val settings = Seq(
lazy val jacksonVersion = sys.props.get("fasterxml.jackson.version").getOrElse("2.19.2")
lazy val jacksonDeps = Bom.dependencies("com.fasterxml.jackson" % "jackson-bom" % jacksonVersion)
lazy val settings = jacksonDeps ++ Seq(
dependencyOverrides += "com.google.guava" % "guava" % guavaVersion,
dependencyOverrides ++= jacksonDeps.key.value,
dependencyOverrides += "jline" % "jline" % "2.14.6",
dependencyOverrides += "org.apache.avro" % "avro" % "1.12.0")
}
Expand Down
2 changes: 2 additions & 0 deletions project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,5 @@ addSbtPlugin("com.github.sbt" % "sbt-pom-reader" % "2.5.0")
addSbtPlugin("com.github.sbt.junit" % "sbt-jupiter-interface" % "0.17.0")

addSbtPlugin("com.thesamet" % "sbt-protoc" % "1.0.7")

addSbtPlugin("com.here.platform" % "sbt-bom" % "1.0.29")