[SPARK-6604][PySpark]Specify ip of python server scoket

[Sephiroth-Lin]

In driver now will start a server socket and use a wildcard ip, use 127.0.0.0 is more reasonable, as we only use it by local Python process.
/cc @davies

[WangTaoTheTonic]

ok to test

[WangTaoTheTonic]

Jenkins, test this please.

[davies]

LGTM

[SparkQA]

Test build #631 has finished for PR 5256 at commit c88bee9.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.
• This patch does not change any dependencies.

[JoshRosen]

There was some previous discussion of localhost vs 127.0.0.1 at #3425 and I think the conclusion there was against this change. @davies, do your comments there about 127.0.0.1 sometimes being not portable (e.g. IPv6-only machines) still apply here?

[davies]

@JoshRosen Changing the bind address to localhost is reasonable, but we have not figured out a good way to specify local interface, localhost or 127.0.0.1 both have PRO and CON, either one is better than another, so I against to change localhost to 127.0.0.1 without good reason.

I'd vote +1 for * -> 127.0.0.1 change, -0 for localhost -> 127.0.0.1.

[srowen]

(Related discussion was #3425 ^D^D^D which you already found. Can this use "localhost" for consistency with https://docs.python.org/2/library/socketserver.html ? FWIW the current code looks equivalent to passing InetAddress.anyLocalAddress() which is different indeed from localhost.)

[srowen]

@Sephiroth-Lin can you rebase this? and does it make sense to refer to "localhost" instead? Consider also that we have Utils.localHostName() which is an attempt to standardize what is meant by "the address of the local machine"

[Sephiroth-Lin]

@srowen OK, thanks.

[srowen]

LGTM pending tests.

[SparkQA]

Test build #685 has finished for PR 5256 at commit 7b3c633.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.
• This patch adds the following new dependencies:
  • commons-math3-3.4.1.jar
  • snappy-java-1.1.1.7.jar
• This patch removes the following dependencies:
  • commons-math3-3.1.1.jar
  • snappy-java-1.1.1.6.jar

[Sephiroth-Lin]

Jenkins, retest this please.

[SparkQA]

Test build #688 has finished for PR 5256 at commit 7b3c633.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.
• This patch does not change any dependencies.

[srowen]

Test failure looks unrelated as it's not in Python, but let me try one more time.

[srowen]

Jenkins, retest this please

[SparkQA]

Test build #30474 has finished for PR 5256 at commit 7b3c633.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.
• This patch does not change any dependencies.