[SPARK-53850][SDP] Define proto for Sinks and Rename DefineDataset to DefineOutput #52553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaqiWang18
force-pushed
the
SPARK-53850-sdp-sinks-proto
branch
from
9ace5ed to
cc15705
Compare
This reverts commit cc15705.
JiaqiWang18
force-pushed
the
SPARK-53850-sdp-sinks-proto
branch
from
8ad194c to
f5a5fef
Compare
JiaqiWang18
force-pushed
the
SPARK-53850-sdp-sinks-proto
branch
from
f5a5fef to
2541b01
Compare
Contributor
Author
sryza
requested changes
Oct 9, 2025
| } | ||
|
|
||
| // Metadata that's only applicable to external sinks. | ||
| message ExternalSinkDetails { |
Contributor
There was a problem hiding this comment.
Any particular reason we need "external" in the name? Why not just call them "sink details"?
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto
Outdated
Show resolved
Hide resolved
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto
Outdated
Show resolved
Hide resolved
JiaqiWang18
changed the title
Contributor
Author
|
Also had to do some code related refactoring since |
sryza
approved these changes
Oct 9, 2025
Contributor
sryza
left a comment
sryza
left a comment
There was a problem hiding this comment.
One small comment – otherwise LGTM!
| // The type of output. | ||
| enum OutputType { | ||
| // Safe default value. Should not be used. | ||
| DATASET_TYPE_UNSPECIFIED = 0; |
Contributor
There was a problem hiding this comment.
Should this be OUTPUT_TYPE_UNSPECIFIED?
Contributor
Author
There was a problem hiding this comment.
good catch, fixed
Member
|
+1, LGTM, too. |
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Oct 27, 2025
…th `4.1.0-preview3` RC1 ### What changes were proposed in this pull request? This PR aims to update Spark Connect-generated Swift source code with Apache Spark `4.1.0-preview3` RC1. ### Why are the changes needed? There are many changes between Apache Spark 4.1.0-preview2 and preview3. - apache/spark#52685 - apache/spark#52613 - apache/spark#52553 - apache/spark#52532 - apache/spark#52517 - apache/spark#52514 - apache/spark#52487 - apache/spark#52328 - apache/spark#52200 - apache/spark#52154 - apache/spark#51344 To use the latest bug fixes and new messages to develop for new features of `4.1.0-preview3`. ``` $ git clone -b v4.1.0-preview3 https://github.com/apache/spark.git $ cd spark/sql/connect/common/src/main/protobuf/ $ protoc --swift_out=. spark/connect/*.proto $ protoc --grpc-swift_out=. spark/connect/*.proto // Remove empty GRPC files $ cd spark/connect $ grep 'This file contained no services' * | awk -F: '{print $1}' | xargs rm ``` ### Does this PR introduce _any_ user-facing change? Pass the CIs. ### How was this patch tested? Pass the CIs. I manually tested with `Apache Spark 4.1.0-preview3` (with the two SDP ignored tests). ``` $ swift test --no-parallel ... ✔ Test run with 203 tests in 21 suites passed after 19.088 seconds. ``` ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #252 from dongjoon-hyun/SPARK-54043. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
… DefineOutput ### What changes were proposed in this pull request? * Create the spark connect proto for SDP sinks * The encapsulating `DefineDataset` renamed to `DefineOutput` since sink isn't a "dataset". ### Why are the changes needed? To be able to issue these requests from client to server. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Proto changes ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#52553 from JiaqiWang18/SPARK-53850-sdp-sinks-proto. Authored-by: Jacky Wang <[email protected]> Signed-off-by: Sandy Ryza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DefineDatasetrenamed toDefineOutputsince sink isn't a "dataset".Why are the changes needed?
To be able to issue these requests from client to server.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Proto changes
Was this patch authored or co-authored using generative AI tooling?
No