[SPARK-53593][SDP] Fix: Use unquoted for response fields #52483
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookiedough77
changed the title
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? This PR fixes the bug where quoted names were being set in the proto response fields for catalog, database, and identifier. Changes include: - Removing the use of quoteIdentifier when populating resolvedCatalog, resolvedDb, and resolvedId in the proto response. - Updating the code to return the raw catalog, database, and identifier values from CatalystIdentifier instead. - Adjusting unit tests in SparkDeclarativePipelinesServerSuite to validate that proto fields contain unquoted strings, even when names contain special characters like backticks. ### Why are the changes needed? Quoted names are only required when constructing fully qualified string identifiers (e.g., `cat`.`db`.`table`). Proto messages keep catalog, database, and identifier as separate fields and should store the raw values. Returning quoted names in proto fields was a bug and could cause inconsistencies in client usage. ### Does this PR introduce _any_ user-facing change? Yes. The proto responses for dataset and flow definitions will now return raw catalog, database, and identifier values instead of quoted versions. For example, a catalog named a`b will be returned as a\bin the proto field, not ``ab` . ### How was this patch tested? Updated SparkDeclarativePipelinesServerSuite to verify that proto fields contain raw, unquoted names. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52483 from cookiedough77/jessie.luo-data/use-unquoted-for-resolvedidentifier. Authored-by: Jessie Luo <[email protected]> Signed-off-by: Sandy Ryza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the bug where quoted names were being set in the proto response fields for catalog, database, and identifier.
Changes include:
Why are the changes needed?
Quoted names are only required when constructing fully qualified string identifiers (e.g.,
cat.db.table). Proto messages keep catalog, database, and identifier as separate fields and should store the raw values. Returning quoted names in proto fields was a bug and could cause inconsistencies in client usage.Does this PR introduce any user-facing change?
Yes. The proto responses for dataset and flow definitions will now return raw catalog, database, and identifier values instead of quoted versions. For example, a catalog named a
b will be returned as a\bin the proto field, not ``ab.How was this patch tested?
Updated SparkDeclarativePipelinesServerSuite to verify that proto fields contain raw, unquoted names.
Was this patch authored or co-authored using generative AI tooling?
No.