[SPARK-53112][PYTHON][TESTS][FOLLOW-UP] Remove some tests for Non-ANSI #52466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
LuciferYang
reviewed
Sep 26, 2025
| with self.assertRaises(Exception): | ||
| F.make_timestamp_ntz(date=df_dt.date) | ||
|
|
||
| # Test 17: Invalid data types - should raise exception for invalid string to int cast |
Contributor
There was a problem hiding this comment.
How about changing it to
with self.sql_conf({"spark.sql.ansi.enabled": True}):
# Test 17: Invalid data types - should raise exception for invalid string to int cast
with self.assertRaises(Exception):
self.spark.range(1).select(
F.make_timestamp_ntz(
F.lit("invalid"), F.lit(5), F.lit(22), F.lit(10), F.lit(30), F.lit(0)
)
).collect()
....
Contributor
Author
There was a problem hiding this comment.
I feel we don't need to check this from pyspark's, it is guaranteed by spark sql.
LuciferYang
approved these changes
Sep 26, 2025
Contributor
Author
|
merged to master |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? remove some newly added tests which failed in non-ansi see https://github.com/apache/spark/actions/runs/18025276597/job/51291154866 ``` ====================================================================== FAIL [1.563s]: test_make_timestamp_ntz (pyspark.sql.tests.test_functions.FunctionsTests.test_make_timestamp_ntz) Comprehensive test cases for make_timestamp_ntz with various arguments and edge cases. ---------------------------------------------------------------------- Traceback (most recent call last): File "/__w/spark/spark/python/pyspark/sql/tests/test_functions.py", line 999, in test_make_timestamp_ntz with self.assertRaises(Exception): AssertionError: Exception not raised ---------------------------------------------------------------------- ``` ### Why are the changes needed? to make non-ansi schedule job happy ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? manually check ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#52466 from zhengruifeng/remove_ansi_test. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
remove some newly added tests which failed in non-ansi
see https://github.com/apache/spark/actions/runs/18025276597/job/51291154866
Why are the changes needed?
to make non-ansi schedule job happy
Does this PR introduce any user-facing change?
no
How was this patch tested?
manually check
Was this patch authored or co-authored using generative AI tooling?
no