[SPARK-53112][SQL][PYTHON][CONNECT][FOLLOW-UP] Change date and time to be positional arguments #52461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
Sep 26, 2025
Contributor
|
thanks @Yicong-Huang |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…o be positional arguments ### What changes were proposed in this pull request? Use positional arguments for `date` and `time` fields in `make_timestamp_ntz` and `try_make_timestamp_ntz`. ### Why are the changes needed? To fix the unnecessary requirement of them being keyword arguments. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit tests in place. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52461 from Yicong-Huang/SPARK-53112/fix/use-positional-arguments. Authored-by: Yicong-Huang <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use positional arguments for
dateandtimefields inmake_timestamp_ntzandtry_make_timestamp_ntz.Why are the changes needed?
To fix the unnecessary requirement of them being keyword arguments.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests in place.
Was this patch authored or co-authored using generative AI tooling?
No.