[SPARK-53694][SQL][TESTS] Improve V1WriteHiveCommandSuite test coverage
#52436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @cloud-fan |
Member
There was a problem hiding this comment.
According to the claims, why don't we use spark.sql.legacy.createHiveTableByDefault=(true|false) explicitly to improve the test coverage, @pan3793 ?
Previously, V1WriteHiveCommandSuite uses CREATE TABLE without declaring USING or STORED AS, which relies on spark.sql.legacy.createHiveTableByDefault's default value, SPARK-46122 changes the default value of spark.sql.legacy.createHiveTableByDefault from true to false, which implicitly affects this test suite.
Member
Author
|
@dongjoon-hyun the test suite hierarchy is
|
cloud-fan
approved these changes
Sep 25, 2025
dongjoon-hyun
approved these changes
Sep 25, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Got it., @pan3793 .
dongjoon-hyun
changed the title
V1WriteHiveCommandSuite test coverage
Member
|
Merged to master for Apache Spark 4.1.0-preview3. |
pan3793
added a commit
to pan3793/spark
that referenced
this pull request
Oct 21, 2025
…rage ### What changes were proposed in this pull request? Previously, `V1WriteHiveCommandSuite` uses `CREATE TABLE` without declaring `USING` or `STORED AS`, which relies on `spark.sql.legacy.createHiveTableByDefault`'s default value, SPARK-46122 changes the default value of `spark.sql.legacy.createHiveTableByDefault` from `true` to `false`, which implicitly affects this test suite. In addition, we should take `spark.sql.hive.convertMetastoreParquet` and `spark.sql.hive.convertMetastoreOrc` into account in `V1WriteHiveCommandSuite` ### Why are the changes needed? Restore and improve test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52436 from pan3793/SPARK-53694. Authored-by: Cheng Pan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
peter-toth
pushed a commit
that referenced
this pull request
Oct 21, 2025
… coverage Backport #52436 to branch-4.0 to recover CI. ### What changes were proposed in this pull request? Previously, `V1WriteHiveCommandSuite` uses `CREATE TABLE` without declaring `USING` or `STORED AS`, which relies on `spark.sql.legacy.createHiveTableByDefault`'s default value, SPARK-46122 changes the default value of `spark.sql.legacy.createHiveTableByDefault` from `true` to `false`, which implicitly affects this test suite. In addition, we should take `spark.sql.hive.convertMetastoreParquet` and `spark.sql.hive.convertMetastoreOrc` into account in `V1WriteHiveCommandSuite` ### Why are the changes needed? Restore and improve test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52683 from pan3793/SPARK-53694-4.0. Authored-by: Cheng Pan <[email protected]> Signed-off-by: Peter Toth <[email protected]>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
… coverage Backport apache#52436 to branch-4.0 to recover CI. ### What changes were proposed in this pull request? Previously, `V1WriteHiveCommandSuite` uses `CREATE TABLE` without declaring `USING` or `STORED AS`, which relies on `spark.sql.legacy.createHiveTableByDefault`'s default value, SPARK-46122 changes the default value of `spark.sql.legacy.createHiveTableByDefault` from `true` to `false`, which implicitly affects this test suite. In addition, we should take `spark.sql.hive.convertMetastoreParquet` and `spark.sql.hive.convertMetastoreOrc` into account in `V1WriteHiveCommandSuite` ### Why are the changes needed? Restore and improve test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52683 from pan3793/SPARK-53694-4.0. Authored-by: Cheng Pan <[email protected]> Signed-off-by: Peter Toth <[email protected]>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…rage ### What changes were proposed in this pull request? Previously, `V1WriteHiveCommandSuite` uses `CREATE TABLE` without declaring `USING` or `STORED AS`, which relies on `spark.sql.legacy.createHiveTableByDefault`'s default value, SPARK-46122 changes the default value of `spark.sql.legacy.createHiveTableByDefault` from `true` to `false`, which implicitly affects this test suite. In addition, we should take `spark.sql.hive.convertMetastoreParquet` and `spark.sql.hive.convertMetastoreOrc` into account in `V1WriteHiveCommandSuite` ### Why are the changes needed? Restore and improve test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52436 from pan3793/SPARK-53694. Authored-by: Cheng Pan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously,
V1WriteHiveCommandSuiteusesCREATE TABLEwithout declaringUSINGorSTORED AS, which relies onspark.sql.legacy.createHiveTableByDefault's default value, SPARK-46122 changes the default value ofspark.sql.legacy.createHiveTableByDefaultfromtruetofalse, which implicitly affects this test suite.In addition, we should take
spark.sql.hive.convertMetastoreParquetandspark.sql.hive.convertMetastoreOrcinto account inV1WriteHiveCommandSuiteWhy are the changes needed?
Restore and improve test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GHA.
Was this patch authored or co-authored using generative AI tooling?
No.