Skip to content

[SPARK-6571][MLLIB] use wrapper in MatrixFactorizationModel.load #5243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-6571][MLLIB] use wrapper in MatrixFactorizationModel.load #5243

wants to merge 1 commit into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Mar 28, 2015

This fixes predictAll after load. @jkbradley

@SparkQA
Copy link

SparkQA commented Mar 28, 2015

Test build #29350 has started for PR 5243 at commit 82dcaa7.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 28, 2015

Test build #29350 has finished for PR 5243 at commit 82dcaa7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 28, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29350/
Test PASSed.

@jkbradley
Copy link
Member

jkbradley commented Mar 28, 2015

LGTM! I'll merge it into branch-1.3 and master

@asfgit asfgit closed this in f75f633 Mar 28, 2015
@jkbradley
Copy link
Member

jkbradley commented Mar 28, 2015

Oops, I guess this requires a little conflict resolution for branch-1.3. Should that be a separate backport PR?

asfgit pushed a commit that referenced this pull request Mar 30, 2015
@mengxr
[SPARK-6571][MLLIB] use wrapper in MatrixFactorizationModel.load
93a7166 
This fixes `predictAll` after load. jkbradley

Author: Xiangrui Meng <[email protected]>

Closes #5243 from mengxr/SPARK-6571 and squashes the following commits:

82dcaa7 [Xiangrui Meng] use wrapper in MatrixFactorizationModel.load

(cherry picked from commit f75f633)
Signed-off-by: Xiangrui Meng <[email protected]>

Conflicts:
	mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala
@mengxr
Copy link
Contributor Author

mengxr commented Mar 30, 2015

I've merged this PR into branch-1.3.

@mengxr mengxr mentioned this pull request Mar 31, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mengxr @SparkQA @AmplabJenkins @jkbradley