[SPARK-53637][BUILD] Demote bcprov-jdk18on to test scope #52390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @dongjoon-hyun and @cnauroth |
dongjoon-hyun
approved these changes
Sep 18, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (Pending CIs) for Apache Spark 4.1.0-preview2.
Thank you, @pan3793 .
cnauroth
reviewed
Sep 18, 2025
Contributor
cnauroth
left a comment
cnauroth
left a comment
There was a problem hiding this comment.
@pan3793 , thank you for taking care of this. Does LICENSE-binary need an update too?
https://github.com/apache/spark/blob/master/LICENSE-binary#L482
peter-toth
approved these changes
Sep 18, 2025
Member
Author
|
@cnauroth right, thanks for catching this, removed. |
cnauroth
approved these changes
Sep 18, 2025
Contributor
cnauroth
left a comment
cnauroth
left a comment
There was a problem hiding this comment.
+1 (non-binding). Thanks for the update!
Member
|
Merged to master for Apache Spark 4.1.0-preview2. |
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 22, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `bouncycastle` to 1.82. Note that `bouncycastle` was demoted to the `test` scope after Apache Hadoop 3.4.2 - #52390 - [HADOOP-19152: Do not hard code security providers](https://issues.apache.org/jira/browse/HADOOP-19152) ### Why are the changes needed? - Release Note: https://www.bouncycastle.org/download/bouncy-castle-java/?filter=java%3Drelease-1-82 ### Does this PR introduce _any_ user-facing change? No, this is a test dependency change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52407 from dongjoon-hyun/SPARK-53661. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? This PR logically reverts SPARK-51311. ### Why are the changes needed? HADOOP-19152 has already been included in Hadoop 3.4.2 via apache/hadoop#7439, the previous workaround is unnecessary anymore. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? I manually tested it in a kerberized cluster with a SparkPi. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52390 from pan3793/SPARK-53637. Authored-by: Cheng Pan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `bouncycastle` to 1.82. Note that `bouncycastle` was demoted to the `test` scope after Apache Hadoop 3.4.2 - apache#52390 - [HADOOP-19152: Do not hard code security providers](https://issues.apache.org/jira/browse/HADOOP-19152) ### Why are the changes needed? - Release Note: https://www.bouncycastle.org/download/bouncy-castle-java/?filter=java%3Drelease-1-82 ### Does this PR introduce _any_ user-facing change? No, this is a test dependency change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52407 from dongjoon-hyun/SPARK-53661. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR logically reverts SPARK-51311.
Why are the changes needed?
HADOOP-19152 has already been included in Hadoop 3.4.2 via apache/hadoop#7439, the previous workaround is unnecessary anymore.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
I manually tested it in a kerberized cluster with a SparkPi.
Was this patch authored or co-authored using generative AI tooling?
No.