[SPARK-53625][SS] Propagate metadata columns through projections to address ApplyCharTypePadding incompatibility #52375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartSaVioR
reviewed
Sep 18, 2025
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
Looks great in overall - I have slight concern with the config name but others are great. Thanks for fixing this!
@cloud-fan Would you mind taking a look?
| .booleanConf | ||
| .createWithDefault(true) | ||
|
|
||
| val STREAMING_PROJECT_METADATA_COLS_ENABLED = |
Contributor
There was a problem hiding this comment.
This is too general and could mislead the impact of the config. We'd need to mention DSv1 and getBatch (or microbatch plan for the source) in the config name to scope it correctly.
Contributor
There was a problem hiding this comment.
or we just remove the config. It's a bug fix and we get error anyway without this fix. It can't be worse.
Contributor
There was a problem hiding this comment.
Makes sense to me. @liviazhu Let's remove this config.
...core/src/test/scala/org/apache/spark/sql/execution/datasources/FileMetadataStructSuite.scala
Outdated
Show resolved
Hide resolved
| ) | ||
|
|
||
| checkAnswer( | ||
| newDF.where(s"$METADATA_FILE_SIZE > 0").select(METADATA_FILE_SIZE), |
Contributor
There was a problem hiding this comment.
.where(s"$METADATA_FILE_SIZE > 0")
I guess this is just a sanity check, right? Is this ever possible where a row is mapped to some file while the file has size 0?
Contributor
Author
There was a problem hiding this comment.
Yeah just a sanity check
HeartSaVioR
changed the title
HeartSaVioR
approved these changes
Sep 18, 2025
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
+1
The test failure is unrelated - it only failed with SDP test suite which is due to unavailability of 'yaml' library.
Contributor
|
I discussed this with @cloud-fan yesterday and he was OK with the fix. I'm going to merge. Thanks! Merging to master/4.0. |
HeartSaVioR
pushed a commit
that referenced
this pull request
Sep 19, 2025
…ddress ApplyCharTypePadding incompatibility ### What changes were proposed in this pull request? Modify streaming MicrobatchExecution to propagate metadata columns through projections to resolve an incompatibility with the ApplyCharTypePadding rule which is applied by default in serverless which previous resulted in an `assertion failed: Invalid batch: ACTV_IND#130290,_metadata#130291 != ACTV_IND#130307` error. ### Why are the changes needed? Bug fix ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests ### Was this patch authored or co-authored using generative AI tooling? No Closes #52375 from liviazhu/liviazhu-db/col-metadata. Authored-by: Livia Zhu <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]> (cherry picked from commit a8bb8b0) Signed-off-by: Jungtaek Lim <[email protected]>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…ddress ApplyCharTypePadding incompatibility ### What changes were proposed in this pull request? Modify streaming MicrobatchExecution to propagate metadata columns through projections to resolve an incompatibility with the ApplyCharTypePadding rule which is applied by default in serverless which previous resulted in an `assertion failed: Invalid batch: ACTV_IND#130290,_metadata#130291 != ACTV_IND#130307` error. ### Why are the changes needed? Bug fix ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#52375 from liviazhu/liviazhu-db/col-metadata. Authored-by: Livia Zhu <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]> (cherry picked from commit f8ee085) Signed-off-by: Jungtaek Lim <[email protected]>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…ddress ApplyCharTypePadding incompatibility ### What changes were proposed in this pull request? Modify streaming MicrobatchExecution to propagate metadata columns through projections to resolve an incompatibility with the ApplyCharTypePadding rule which is applied by default in serverless which previous resulted in an `assertion failed: Invalid batch: ACTV_IND#130290,_metadata#130291 != ACTV_IND#130307` error. ### Why are the changes needed? Bug fix ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#52375 from liviazhu/liviazhu-db/col-metadata. Authored-by: Livia Zhu <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modify streaming MicrobatchExecution to propagate metadata columns through projections to resolve an incompatibility with the ApplyCharTypePadding rule which is applied by default in serverless which previous resulted in an
assertion failed: Invalid batch: ACTV_IND#130290,_metadata#130291 != ACTV_IND#130307error.Why are the changes needed?
Bug fix
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No