Skip to content

[SPARK-53422][SQL][TEST] Make SPARK-30269 test case robust #52168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pan3793 wants to merge 2 commits into from
Closed

[SPARK-53422][SQL][TEST] Make SPARK-30269 test case robust #52168

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb97896
[SPARK-53422][SQL][TEST] Make SPARK-30269 test robust
pan3793 Aug 28, 2025
beee306
assert stats is none before executing ANALYZE TABLE
pan3793 Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1616,11 +1616,10 @@ class StatisticsSuite extends StatisticsCollectionTestBase with TestHiveSingleto
Seq(tbl, ext_tbl).foreach { tblName =>
sql(s"INSERT INTO $tblName VALUES (1, 'a', '2019-12-13')")

val expectedSize = 690
Copy link
Member

@yaooqinn yaooqinn Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we compare with the size as unexpected before insertion instead?

Copy link
Member Author

@pan3793 pan3793 Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when spark.sql.statistics.size.autoUpdate.enabled is false (it's the default value), table stats is None until executing ANALYZE TABLE ...

I update the test to reflect that.

// analyze table
sql(s"ANALYZE TABLE $tblName COMPUTE STATISTICS NOSCAN")
var tableStats = getTableStats(tblName)
assert(tableStats.sizeInBytes == expectedSize)
val expectedSize = tableStats.sizeInBytes
Copy link
Member

@dongjoon-hyun dongjoon-hyun Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is a removal of test coverage technically, @pan3793 .

This test case is a known issue which fails due to the Parquet metadata (mostly version string) change. However, I'd like not to remove this test coverage.

Copy link
Member Author

@pan3793 pan3793 Aug 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the original PR, the intention of this test is to make sure partition stats get updated, even though it equals existing table stats. The number of table's sizeInBytes does not really matter here.

Generally, asserting the size of binary data files like Parquet/ORC does not make sense, it can vary due to metadata change, as you pointed out, this is likely caused by the version string change, and also might be affected by the compression codec, the compressed data length might be different in different snappy version or platform.

assert(tableStats.rowCount.isEmpty)

sql(s"ANALYZE TABLE $tblName COMPUTE STATISTICS")
Expand Down