[SPARK-51874][SQL][FOLLOW-UP] Revert ParquetOptions rebase methods to return string type #52065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @yaooqinn |
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Aug 18, 2025
Contributor
Author
|
thanks for the review, merging to master! |
cloud-fan
added a commit
that referenced
this pull request
Aug 20, 2025
… DataSourceUtils and AvroOptions ### What changes were proposed in this pull request? A similar followup PR of #52065 . This PR restores the rebase APIs in `DataSourceUtils` for compatibility with external Spark plugins, and also in `AvroOptions` to simplify the code. ### Why are the changes needed? External plugins may use `DataSourceUtils` directly, see https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark3.5.x/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/Spark35LegacyHoodieParquetFileFormat.scala#L194 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? no Closes #52074 from cloud-fan/follow. Lead-authored-by: Wenchen Fan <[email protected]> Co-authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #50674 . In that PR, we made it easier to define sql configs with enum values, and we also refactored some code to make things simpler.
This PR reverts the API changes of
ParquetOptions. Ideally we can change private APIs, but Parquet is a very popular format and there are third-party spark plugins that use Parquet related private APIs in Spark. We can of course ask these Spark plugins to update their code or add shim layers, but it's more friendly to avoid breaking certain private APIs if easy.Why are the changes needed?
avoid breaking private APIs that used by Spark plugins, such as https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark3.5.x/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/Spark35LegacyHoodieParquetFileFormat.scala#L150
Does this PR introduce any user-facing change?
no
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
no