[SPARK-53319][SQL] Support the time type by try_make_timestamp_ltz() #52063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
changed the title
Contributor
Author
jcw024
reviewed
Aug 28, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Show resolved
Hide resolved
|
changes look good, but I see the build is failing. Seems like it could be a transient issue, can you try rerunning the build? |
Contributor
Author
|
Docker Integration failure looks unrelated to these changes, re-running to confirm. |
|
cc @cloud-fan for review |
Contributor
Author
|
@cloud-fan Please review. |
cloud-fan
reviewed
Oct 14, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
…essions/datetimeExpressions.scala
cloud-fan
reviewed
Oct 14, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Oct 22, 2025
Contributor
|
thanks, merging to master! |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? In the PR, I propose to extend the `try_make_timestamp_ltz` function, and accept a date and time fields. **Syntax** ``` try_make_timestamp_ltz(date[, time]) ``` **Arguments** - `date`: A date expression. - `time`: A time expression. **Returns** A `TIMESTAMP_LTZ`. Examples ``` > SELECT try_make_timestamp_ltz(DATE'2014-12-28', TIME'6:30:45.887'); 2014-12-28 06:30:45.887 ``` ### Why are the changes needed? Users will be able to create a timestamp with local time zone by combining a time and a date. ### Does this PR introduce _any_ user-facing change? Yes, this extends `try_make_timestamp_ltz` to accept additional kinds of inputs. ### How was this patch tested? Added new e2e SQL tests in corresponding golden files. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52063 from uros-db/try_make_timestamp_ltz. Lead-authored-by: Uros Bojanic <[email protected]> Co-authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to extend the
try_make_timestamp_ltzfunction, and accept a date and time fields.Syntax
Arguments
date: A date expression.time: A time expression.Returns
A
TIMESTAMP_LTZ.Examples
Why are the changes needed?
Users will be able to create a timestamp with local time zone by combining a time and a date.
Does this PR introduce any user-facing change?
Yes, this extends
try_make_timestamp_ltzto accept additional kinds of inputs.How was this patch tested?
Added new e2e SQL tests in corresponding golden files.
Was this patch authored or co-authored using generative AI tooling?
No.