Skip to content

[SPARK-53128][CORE] Include unmanaged memory bytes in the usage log before execution memory OOM #51848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhztheplayer wants to merge 2 commits into from
Closed

[SPARK-53128][CORE] Include unmanaged memory bytes in the usage log before execution memory OOM #51848

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3ed2af
[SPARK-53128][CORE] Include unmanaged memory bytes in the usage log b…
zhztheplayer Aug 5, 2025
25d34b7
fixup
zhztheplayer Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,9 +339,12 @@ public void showMemoryUsage() {
MDC.of(LogKeys.MEMORY_SIZE, memoryNotAccountedFor),
MDC.of(LogKeys.TASK_ATTEMPT_ID, taskAttemptId));
logger.info(
"{} bytes of memory are used for execution and {} bytes of memory are used for storage",
"{} bytes of memory are used for execution " +
"and {} bytes of memory are used for storage " +
"and {} bytes of memory are used but unmanaged",
Copy link
Member

@dongjoon-hyun dongjoon-hyun Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but this might sounds misleading. Can we revise this like the following, @zhztheplayer ?

- and {} bytes of memory are used but unmanaged
+ and {} bytes of unmanaged memory are used

Copy link
Member Author

@zhztheplayer zhztheplayer Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi dongjoon-hyun, just to clarify, I guess you were suggesting to only change the 3rd sentence here?

MDC.of(LogKeys.EXECUTION_MEMORY_SIZE, memoryManager.executionMemoryUsed()),
MDC.of(LogKeys.STORAGE_MEMORY_SIZE, memoryManager.storageMemoryUsed()));
MDC.of(LogKeys.STORAGE_MEMORY_SIZE, memoryManager.storageMemoryUsed()),
MDC.of(LogKeys.MEMORY_SIZE, UnifiedMemoryManager$.MODULE$.getUnmanagedMemoryUsed()));
}
}

Expand Down
8 changes: 8 additions & 0 deletions core/src/main/scala/org/apache/spark/memory/UnifiedMemoryManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,14 @@ object UnifiedMemoryManager extends Logging {
// Atomic flag to ensure polling is only started once per JVM
private val pollingStarted = new AtomicBoolean(false)

/**
* Returns the total unmanaged memory in bytes, including both
* on-heap unmanaged memory and off-heap unmanaged memory.
*/
private[spark] def getUnmanagedMemoryUsed: Long = {
UnifiedMemoryManager.unmanagedOnHeapUsed.get() + UnifiedMemoryManager.unmanagedOffHeapUsed.get()
}

/**
* Register an unmanaged memory consumer to track its memory usage.
*
Expand Down