-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-53112][SQL][PYTHON][CONNECT] Support TIME in the make_timestamp_ntz and try_make_timestamp_ntz functions in PySpark #51831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
ff9c6d6
Initial commit
uros-db 4e79dd8
Cleanup
uros-db a6bf88d
Merge branch 'apache:master' into python-try_make_timestamp_ntz
uros-db c707a1e
Python linter
uros-db 53b30e9
Update tests
uros-db 87c2327
Python lint fixes
uros-db 3a6e03a
Python lint fixes
uros-db 8180018
fix: doc-string
Yicong-Huang 853b9c8
fix: doc-string
Yicong-Huang 46f6b10
fix: doc-string
Yicong-Huang eadad20
wip: use keyword arguments only
Yicong-Huang ce643c2
use keyword arguments for date and time
Yicong-Huang b5936cf
refactor: clean up docstrings for make_timestamp_ntz function
Yicong-Huang 91740e6
refactor: improve code readability in make_timestamp_ntz function by …
Yicong-Huang da60214
refactor: replace __builtins__ sum calls with built-in sum for improv…
Yicong-Huang 338a23d
refactor: enhance try_make_timestamp_ntz function with improved argum…
Yicong-Huang d581527
refactor: enhance make_timestamp_ntz and try_make_timestamp_ntz funct…
Yicong-Huang a868cf2
refactor: update comments in make_timestamp_ntz and try_make_timestam…
Yicong-Huang 83f701f
refactor: add type casting for arguments in make_timestamp_ntz and tr…
Yicong-Huang 0d1f37b
refactor: enforce keyword-only arguments in make_timestamp_ntz functi…
Yicong-Huang 860fc53
refactor: replace keyword-only arguments with *args in make_timestamp…
Yicong-Huang 260df29
refactor: swap error message keys for clarity in error-conditions.json
Yicong-Huang 93c99bd
refactor: simplify make_timestamp_ntz usage by removing mixed argumen…
Yicong-Huang 873cf4a
refactor: streamline make_timestamp_ntz and try_make_timestamp_ntz fu…
Yicong-Huang 66e1685
refactor: update error handling in make_timestamp_ntz to use CANNOT_S…
Yicong-Huang bb42aeb
refactor: improve argument validation and error handling in make_time…
Yicong-Huang 31f33a9
refactor: enhance try_make_timestamp_ntz function to handle None para…
Yicong-Huang 0696390
test: expand make_timestamp_ntz test cases to cover various argument …
Yicong-Huang 6fb47d8
fix: shorten doc string
Yicong-Huang a704c54
doc: add more examples in doc-string
Yicong-Huang d028c14
test: update exception handling in make_timestamp_ntz tests to raise …
Yicong-Huang 107ac4f
test: remove unused imports in make_timestamp_ntz test cases for clea…
Yicong-Huang 5acd80c
doc: format output examples in make_timestamp_ntz documentation for i…
Yicong-Huang a3be61c
refactor: update try_make_timestamp_ntz function to use casting for p…
Yicong-Huang b824f78
refactor: enhance try_make_timestamp_ntz function to raise PySparkVal…
Yicong-Huang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we change the argument names?
does it break this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah let's don't change the name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted this change. using keyword arguments for new
dateandtimearguments.