Skip to content

[SPARK-6437][SQL] Use completion iterator to close external sorter #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marmbrus wants to merge 2 commits into from
Closed

[SPARK-6437][SQL] Use completion iterator to close external sorter #5161

marmbrus wants to merge 2 commits into from

Conversation

@marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Mar 24, 2015

Otherwise we will leak files when spilling occurs.

@SparkQA
Copy link

SparkQA commented Mar 24, 2015

Test build #29067 has finished for PR 5161 at commit cdebdf5.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 24, 2015

Test build #29070 has finished for PR 5161 at commit cb13d3c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Mar 24, 2015

LGTM

asfgit pushed a commit that referenced this pull request Mar 24, 2015
@marmbrus
[SPARK-6437][SQL] Use completion iterator to close external sorter
c0101d3 
Otherwise we will leak files when spilling occurs.

Author: Michael Armbrust <[email protected]>

Closes #5161 from marmbrus/cleanupAfterSort and squashes the following commits:

cb13d3c [Michael Armbrust] hint to inferencer
cdebdf5 [Michael Armbrust] Use completion iterator to close external sorter

(cherry picked from commit 26c6ce3)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in 26c6ce3 Mar 24, 2015
@marmbrus marmbrus deleted the cleanupAfterSort branch August 3, 2015 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marmbrus @SparkQA @yhuai