Skip to content

[SPARK-6375][SQL] Fix formatting of error messages. #5155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marmbrus wants to merge 1 commit into from
Closed

[SPARK-6375][SQL] Fix formatting of error messages. #5155

marmbrus wants to merge 1 commit into from

Conversation

@marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Mar 24, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Mar 24, 2015

Test build #29056 has finished for PR 5155 at commit b898188.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

yhuai
yhuai reviewed Mar 24, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
Copy link
Contributor

@yhuai yhuai Mar 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a TODO at here about using backticks to quote any part of the identifier having . in the string?

@yhuai
Copy link
Contributor

yhuai commented Mar 24, 2015

LGTM (we can add the TODO later or we can just do that when we fix https://issues.apache.org/jira/browse/SPARK-2775)

asfgit pushed a commit that referenced this pull request Mar 24, 2015
@marmbrus
[SPARK-6375][SQL] Fix formatting of error messages.
92bf888 
Author: Michael Armbrust <[email protected]>

Closes #5155 from marmbrus/errorMessages and squashes the following commits:

b898188 [Michael Armbrust] Fix formatting of error messages.

(cherry picked from commit 046c1e2)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in 046c1e2 Mar 24, 2015
@marmbrus marmbrus deleted the errorMessages branch August 3, 2015 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marmbrus @SparkQA @yhuai