Skip to content

[SPARK-52803][BUILD] Update aws-java-sdk-sts to 1.12.720 in kinesis-asl module #51498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eschcam wants to merge 2 commits into from
Closed

[SPARK-52803][BUILD] Update aws-java-sdk-sts to 1.12.720 in kinesis-asl module #51498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
350cb44
[SPARK-52803][BUILD] Update aws-java-sdk-s3 to 1.12.261
eschcam Jul 15, 2025
9bae3d5
[SPARK-52803][BUILD] Update aws-java-sdk-sts to 1.12.720
eschcam Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
<avro.version>1.12.0</avro.version>
<aws.kinesis.client.version>1.12.0</aws.kinesis.client.version>
<!-- Should be consistent with Kinesis client dependency -->
<aws.java.sdk.version>1.11.655</aws.java.sdk.version>
<aws.java.sdk.version>1.12.720</aws.java.sdk.version>

@dongjoon-hyun dongjoon-hyun Jul 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, could you double-check that this is consistent with Kinesis client dependency? The line 160 show a requirement for kinesis-asl module.

@eschcam eschcam Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 1.15.3 of amazon-kinesis-client seems to use version 1.12.681 of the aws-java-sdk libs https://mvnrepository.com/artifact/com.amazonaws/amazon-kinesis-client/1.15.3

@eschcam eschcam Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more recent versions of the client appear to use the V2 versions of the SDK https://mvnrepository.com/artifact/software.amazon.kinesis/amazon-kinesis-client/3.1.1

@dongjoon-hyun dongjoon-hyun Jul 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked the pom file. Unfortunately, it seems that we cannot change this dependency while we are using aws-kinesis-client 1.12.0.

<aws.kinesis.client.version>1.12.0</aws.kinesis.client.version>

@eschcam eschcam Jul 17, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would updating aws-kinesis-client to 1.15.3 and aws-java-sdk-sts to 1.12.681 be okay?

@dongjoon-hyun dongjoon-hyun Jul 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, it requires a manual testing for this module. Can you verify it with the real AWS Kinesis? Unfortunately, there were a few attempts on this module but nobody verified their updates with the real AWS Kinesis. That's the reason why this module is sitting on AWS SKD v1 exceptionally.

@eschcam eschcam Jul 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I'm only seeing your comment now.
I'm honestly not sure how I would manually test this apart from updating the dependencies and seeing if the exists tests pass.
I'm guessing I'm missing something

<aws.java.sdk.v2.version>2.29.52</aws.java.sdk.v2.version>
<!-- the producer is used in tests -->
<aws.kinesis.producer.version>0.12.8</aws.kinesis.producer.version>
Expand Down