-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-52770][CONNECT] Support TIME type in connect proto
#51464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,6 +69,8 @@ message DataType { | |
|
|
||
| // UnparsedDataType | ||
| Unparsed unparsed = 24; | ||
|
|
||
| Time time = 28; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just for my understanding. Do you know where is 25, 26, 27, @peter-toth ?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately these are not in order. A few lines up: and down: |
||
| } | ||
|
|
||
| // Reserved for geometry and geography types | ||
|
|
@@ -127,6 +129,11 @@ message DataType { | |
| uint32 type_variation_reference = 1; | ||
| } | ||
|
|
||
| message Time { | ||
| optional int32 precision = 1; | ||
| uint32 type_variation_reference = 2; | ||
| } | ||
|
|
||
| message CalendarInterval { | ||
| uint32 type_variation_reference = 1; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a stupid question, when is these method used? why should we change arrow related method when adding connect dataType?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it isn't a stupid question. Arrow is used for streaming data between connect server and clients: (https://spark.apache.org/docs/latest/spark-connect-overview.html#how-spark-connect-works)