[MINOR][PYTHON] Add scipy-stubs to dev/requirements.txt
#51366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| flake8==3.9.0 | ||
| # See SPARK-38680. | ||
| pandas-stubs<1.2.0.54 | ||
| scipy-stubs; python_version>='3.10' |
Member
There was a problem hiding this comment.
Thank you for making a PR, @jorenham .
May I ask why this is limited to Python 3.10+?
BTW, FYI, since Apache Spark 4.1.0 is going to drop Python 3.9, I believe we can remove this condition python_version>='3.10' later.
Member
There was a problem hiding this comment.
cc @HyukjinKwon , @zhengruifeng , @xinrong-meng , @allisonwang-db from #51259
Contributor
Author
There was a problem hiding this comment.
May I ask why this is limited to Python 3.10+?
at the earliest, scipy-stubs supports scipy 1.14, which requires python >=3.10, as per SPEC 0
dongjoon-hyun
approved these changes
Jul 3, 2025
HyukjinKwon
approved these changes
Jul 3, 2025
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
yeah it's fine to add if it's required during the dev setup
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This adds scipy-stubs to the list of optional Python requirements.
Why are the changes needed?
For the same reason as pandas-stubs is already an optional requirement: To improve static typing support and IDE features (autocompletion, inline documentation, etc).
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need; there's no runtime impact :)
Was this patch authored or co-authored using generative AI tooling?
No.