[SPARK-6463] [SQL]AttributeSet.equal should compare size #5133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
|
Jenkins, test this please. |
|
Test build #29010 has started for PR 5133 at commit
|
|
Test build #29010 has finished for PR 5133 at commit
|
|
Test PASSed. |
Contributor
|
Good catch! Would you mind adding a test case? We should probably create a new Suite for |
Contributor
|
Since I really want to include this in 1.3.1 I've fixed the conflicts and added tests here: #5194 Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Mar 26, 2015
Previously this could result in sets compare equals when in fact the right was a subset of the left. Based on #5133 by sisihj Author: sisihj <[email protected]> Author: Michael Armbrust <[email protected]> Closes #5194 from marmbrus/pr/5133 and squashes the following commits: 5ed4615 [Michael Armbrust] fix imports d4cbbc0 [Michael Armbrust] Add test cases 0a0834f [sisihj] AttributeSet.equal should compare size (cherry picked from commit 276ef1c) Signed-off-by: Michael Armbrust <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Mar 26, 2015
Previously this could result in sets compare equals when in fact the right was a subset of the left. Based on #5133 by sisihj Author: sisihj <[email protected]> Author: Michael Armbrust <[email protected]> Closes #5194 from marmbrus/pr/5133 and squashes the following commits: 5ed4615 [Michael Armbrust] fix imports d4cbbc0 [Michael Armbrust] Add test cases 0a0834f [sisihj] AttributeSet.equal should compare size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttributeSet.equal should compare both member and size