-
Notifications
You must be signed in to change notification settings - Fork 29k
Update the command to use IPython notebook #5111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As for "notebook --pylab inline" is not supported any more, update the related documentation for this.
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, it's not supported as of what version -- something old, or recent?
Nit: you can back-tick-quote the %pylab inline bit.
Is it worth explaining what this option does, then? (Could be entirely obvious, just asking.)
|
It is IPython 3.0. I believe one of the motivation of IPython notebook is their inline chart drawing functionality. This is the reason why pylab library is specially mentioned. |
|
But does this then work with ipython 2? I wouldn't want to necessarily 'break' support, even if it's just in an example. Or are two examples called for? Ideally, one example is good, even if it's deprecated in new ipython versions. |
|
The notebook UI is different between 2.4 and new 3.0. But |
|
OK, if this isn't making the example unusable for reasonably recent versions of ipython then it seems OK. Oh, above I was not suggesting that you remove your additional documentation but instead that you explain what the "inline" option was all about? or will it be obvious already? |
|
Let me clarify my opinions more clearly. Hope the above can clarify my opinions. :) |
|
OK, nevermind my question. I think it's clear you know what to do here and it's as you think it should be. I'll leave it open a bit for any other opinions but if it's making the example work for more ipython versions, fine. |
As for "notebook --pylab inline" is not supported any more, update the related documentation for this. Author: Cong Yue <[email protected]> Closes #5111 from yuecong/patch-1 and squashes the following commits: 872df76 [Cong Yue] Update the command to use IPython notebook (cherry picked from commit c12312f) Signed-off-by: Sean Owen <[email protected]>
|
OK I merged this with a couple fixes to the text (e.g. spark -> Spark) |
|
Thanks. |
As for "notebook --pylab inline" is not supported any more, update the related documentation for this.