Skip to content

[SPARK-6428][SQL] Added explicit type for all public methods in sql/core #5104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rxin wants to merge 2 commits into from
Closed

[SPARK-6428][SQL] Added explicit type for all public methods in sql/core #5104

rxin wants to merge 2 commits into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Mar 20, 2015

Also implemented equals/hashCode when they are missing.

This is done in order to enable automatic public method type checking.

@rxin
[SPARK-6428][SQL] Added explicit type for all public methods.
8b36733 
Also implemented equals/hashCode when they are missing.

This is done in order to enable automatic public method type checking.
@SparkQA
Copy link

SparkQA commented Mar 20, 2015

Test build #28916 has started for PR 5104 at commit 8b36733.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 20, 2015

Test build #28916 has finished for PR 5104 at commit 8b36733.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 20, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28916/
Test PASSed.

liancheng
liancheng reviewed Mar 20, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashOuterJoin.scala
Copy link
Contributor

@liancheng liancheng Mar 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pair of braces is redundant.

Copy link
Contributor Author

@rxin rxin Mar 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it is much more clear to have them. this block is pretty long.

@liancheng
Copy link
Contributor

liancheng commented Mar 20, 2015

Left some minor comments, otherwise LGTM.

@rxin rxin changed the title [SPARK-6428][SQL] Added explicit type for all public methods. [SPARK-6428][SQL] Added explicit type for all public methods in sql/core Mar 20, 2015
@SparkQA
Copy link

SparkQA commented Mar 20, 2015

Test build #28933 has started for PR 5104 at commit ffce6f3.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 20, 2015

Test build #28933 has finished for PR 5104 at commit ffce6f3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 20, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28933/
Test PASSed.

@marmbrus
Copy link
Contributor

marmbrus commented Mar 20, 2015

LGTM

@asfgit asfgit closed this in a95043b Mar 20, 2015
asfgit pushed a commit that referenced this pull request Mar 21, 2015
@rxin @marmbrus
[SPARK-6428][SQL] Added explicit type for all public methods in sql/core
c964588 
Also implemented equals/hashCode when they are missing.

This is done in order to enable automatic public method type checking.

Author: Reynold Xin <[email protected]>

Closes #5104 from rxin/sql-hashcode-explicittype and squashes the following commits:

ffce6f3 [Reynold Xin] Code review feedback.
8b36733 [Reynold Xin] [SPARK-6428][SQL] Added explicit type for all public methods.

(cherry picked from commit a95043b)
Signed-off-by: Michael Armbrust <[email protected]>

Conflicts:
	sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala
@marmbrus
Copy link
Contributor

marmbrus commented Mar 21, 2015

backported to branch-1.3

@rxin rxin deleted the sql-hashcode-explicittype branch March 21, 2015 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rxin @SparkQA @AmplabJenkins @liancheng @marmbrus