Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Feb 13, 2025

What changes were proposed in this pull request?

This PR aims to add SparkR deprecation info additionally to the following for developers.

  • README.md
  • make-distribution.sh help message

Why are the changes needed?

SparkR is deprecated properly by the following.

This PR adds a little more because README.md and make-distribution.sh are the starting point for downstream Spark distribution developers.

Does this PR introduce any user-facing change?

No behavior change. Only the documentation and help message of developer script.

How was this patch tested?

Manual review.

$ dev/make-distribution.sh --help 2> /dev/null
make-distribution.sh - tool for making binary distributions of Spark

usage:
make-distribution.sh [--name] [--tgz] [--pip] [--r] [--connect] [--mvn <mvn-command>] <maven build options>
See Spark's "Building Spark" doc for correct Maven options.
SparkR is deprecated from Apache Spark 4.0.0 and will be removed in a future version.

Was this patch authored or co-authored using generative AI tooling?

No

@dongjoon-hyun
Copy link
Member Author

cc @HyukjinKwon

@yaooqinn yaooqinn closed this in 80fb9d0 Feb 13, 2025
yaooqinn pushed a commit that referenced this pull request Feb 13, 2025
…make-distribution.sh` help

### What changes were proposed in this pull request?

This PR aims to add `SparkR` deprecation info additionally to the following for developers.
- `README.md`
- `make-distribution.sh` help message

### Why are the changes needed?

`SparkR` is deprecated properly by the following.
- #47842

This PR adds a little more because `README.md` and `make-distribution.sh` are the starting point for downstream Spark distribution developers.

### Does this PR introduce _any_ user-facing change?

No behavior change. Only the documentation and help message of developer script.

### How was this patch tested?

Manual review.

```
$ dev/make-distribution.sh --help 2> /dev/null
make-distribution.sh - tool for making binary distributions of Spark

usage:
make-distribution.sh [--name] [--tgz] [--pip] [--r] [--connect] [--mvn <mvn-command>] <maven build options>
See Spark's "Building Spark" doc for correct Maven options.
SparkR is deprecated from Apache Spark 4.0.0 and will be removed in a future version.
```

### Was this patch authored or co-authored using generative AI tooling?

No

Closes #49931 from dongjoon-hyun/SPARK-51200.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
(cherry picked from commit 80fb9d0)
Signed-off-by: Kent Yao <[email protected]>
@yaooqinn
Copy link
Member

Merged to master and branch-4.0, thank you @dongjoon-hyun

@dongjoon-hyun
Copy link
Member Author

Thank you, @yaooqinn !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-51200 branch February 13, 2025 14:40
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 14, 2025
…make-distribution.sh` help

### What changes were proposed in this pull request?

This PR aims to add `SparkR` deprecation info additionally to the following for developers.
- `README.md`
- `make-distribution.sh` help message

### Why are the changes needed?

`SparkR` is deprecated properly by the following.
- apache#47842

This PR adds a little more because `README.md` and `make-distribution.sh` are the starting point for downstream Spark distribution developers.

### Does this PR introduce _any_ user-facing change?

No behavior change. Only the documentation and help message of developer script.

### How was this patch tested?

Manual review.

```
$ dev/make-distribution.sh --help 2> /dev/null
make-distribution.sh - tool for making binary distributions of Spark

usage:
make-distribution.sh [--name] [--tgz] [--pip] [--r] [--connect] [--mvn <mvn-command>] <maven build options>
See Spark's "Building Spark" doc for correct Maven options.
SparkR is deprecated from Apache Spark 4.0.0 and will be removed in a future version.
```

### Was this patch authored or co-authored using generative AI tooling?

No

Closes apache#49931 from dongjoon-hyun/SPARK-51200.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
(cherry picked from commit 69b2d4d)
Signed-off-by: Kent Yao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants