[SPARK-51153][BUILD] Remove unused javax.activation:activation dependency
#49876
Conversation
|
It comes from https://github.com/apache/spark/pull/22081/files#r209707448, but after #49854 , it seems that nowhere depends on this. |
cnauroth
left a comment
cnauroth
left a comment
There was a problem hiding this comment.
Agreed, this looks unused now.
A minor request: can you please also remove mention from LICENSE-binary?
https://github.com/apache/spark/blob/master/LICENSE-binary#L504
|
|
||
| Common Development and Distribution License (CDDL) 1.0 | ||
| ------------------------------------------------------ | ||
| javax.activation:activation http://www.oracle.com/technetwork/java/javase/tech/index-jsp-138795.html |
There was a problem hiding this comment.
@cnauroth Here it is. Maybe you didn't notice the change here.
There was a problem hiding this comment.
Thank you, I do see your change there, but it seems there is one more mention in LICENSE-binary at the root of the repo that could be removed:
https://github.com/apache/spark/blob/master/LICENSE-binary#L504
There was a problem hiding this comment.
This is the line 504 of LICENSE-binary, isn't it, @cnauroth ?
There was a problem hiding this comment.
Sorry all, misread this as coming from a different file. Thanks for the patch, @wayneguow .
dongjoon-hyun
changed the title
javax.activation:activation dependencejavax.activation:activation dependency
|
|
…ndency ### What changes were proposed in this pull request? This PR aims to remove unused `javax.activation:activation` dependence. ### Why are the changes needed? Reduce useless dependencies of Spark. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49876 from wayneguow/drop_activation. Authored-by: Wei Guo <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 6416297) Signed-off-by: Dongjoon Hyun <[email protected]>
…ndency ### What changes were proposed in this pull request? This PR aims to remove unused `javax.activation:activation` dependence. ### Why are the changes needed? Reduce useless dependencies of Spark. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49876 from wayneguow/drop_activation. Authored-by: Wei Guo <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 276d1af) Signed-off-by: Dongjoon Hyun <[email protected]>
3 participants
What changes were proposed in this pull request?
This PR aims to remove unused
javax.activation:activationdependence.Why are the changes needed?
Reduce useless dependencies of Spark.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.