Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 31, 2025

What changes were proposed in this pull request?

This PR aims to remove signature from Hive thriftserver DEBUG log.

Why are the changes needed?

This is aligned with the upstream Apache Hive project.

This is also aligned with the previous Spark change.

Does this PR introduce any user-facing change?

No, this is a debug message removal.

How was this patch tested?

Pass the CIs and manual review (because this is a removal).

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Jan 31, 2025
@dongjoon-hyun
Copy link
Member Author

Could you review this PR, too, @huaxingao ?

@dongjoon-hyun
Copy link
Member Author

Could you review this too, @viirya , please?

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya ! 😄

dongjoon-hyun added a commit that referenced this pull request Jan 31, 2025
### What changes were proposed in this pull request?

This PR aims to remove signature from Hive thriftserver DEBUG log.

### Why are the changes needed?

This is aligned with the upstream Apache Hive project.
- apache/hive#4887

This is also aligned with the previous Spark change.
- #43402

### Does this PR introduce _any_ user-facing change?

No, this is a debug message removal.

### How was this patch tested?

Pass the CIs and manual review (because this is a removal).

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49752 from dongjoon-hyun/minor_debug_msg.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 4a33e96)
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun dongjoon-hyun deleted the minor_debug_msg branch January 31, 2025 22:37
@huaxingao
Copy link
Contributor

late LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @huaxingao !

@beliefer
Copy link
Contributor

beliefer commented Feb 1, 2025

late LGTM.

zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 14, 2025
### What changes were proposed in this pull request?

This PR aims to remove signature from Hive thriftserver DEBUG log.

### Why are the changes needed?

This is aligned with the upstream Apache Hive project.
- apache/hive#4887

This is also aligned with the previous Spark change.
- apache#43402

### Does this PR introduce _any_ user-facing change?

No, this is a debug message removal.

### How was this patch tested?

Pass the CIs and manual review (because this is a removal).

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#49752 from dongjoon-hyun/minor_debug_msg.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 04e0ddf)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants