[SPARK-50993][SQL] Move nullDataSourceOption from QueryCompilationErrors into QueryExecutionErrors #49677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @MaxGekk cc @dongjoon-hyun |
…ors to QueryExecutionErrors
MaxGekk
approved these changes
Jan 26, 2025
Member
|
+1, LGTM. Merging to master/4.0. |
MaxGekk
pushed a commit
that referenced
this pull request
Jan 26, 2025
…ors into QueryExecutionErrors ### What changes were proposed in this pull request? This PR proposes to move `nullDataSourceOption` from `QueryCompilationErrors` into `QueryExecutionErrors`. ### Why are the changes needed? Currently, `nullDataSourceOption` is placed into QueryCompilationErrors. In fact, it's an execution error. ### Does this PR introduce _any_ user-facing change? 'Yes'. The type of error will be changed. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes #49677 from beliefer/SPARK-50993. Authored-by: beliefer <[email protected]> Signed-off-by: Max Gekk <[email protected]> (cherry picked from commit e7821c8) Signed-off-by: Max Gekk <[email protected]>
Contributor
Author
|
@MaxGekk Thank you! |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…ors into QueryExecutionErrors ### What changes were proposed in this pull request? This PR proposes to move `nullDataSourceOption` from `QueryCompilationErrors` into `QueryExecutionErrors`. ### Why are the changes needed? Currently, `nullDataSourceOption` is placed into QueryCompilationErrors. In fact, it's an execution error. ### Does this PR introduce _any_ user-facing change? 'Yes'. The type of error will be changed. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes apache#49677 from beliefer/SPARK-50993. Authored-by: beliefer <[email protected]> Signed-off-by: Max Gekk <[email protected]> (cherry picked from commit 07d4cdf) Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to move
nullDataSourceOptionfromQueryCompilationErrorsintoQueryExecutionErrors.Why are the changes needed?
Currently,
nullDataSourceOptionis placed into QueryCompilationErrors.In fact, it's an execution error.
Does this PR introduce any user-facing change?
'Yes'.
The type of error will be changed.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
'No'.