Skip to content

SPARK-6205 [CORE] UISeleniumSuite fails for Hadoop 2.x test with NoClassDefFoundError #4933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srowen wants to merge 1 commit into from
Closed

SPARK-6205 [CORE] UISeleniumSuite fails for Hadoop 2.x test with NoClassDefFoundError #4933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,12 @@
<artifactId>selenium-java</artifactId>
<scope>test</scope>
</dependency>
<!-- Added for selenium: -->
<dependency>
<groupId>xml-apis</groupId>
<artifactId>xml-apis</artifactId>
<scope>test</scope>
Copy link
Contributor

@vanzin vanzin Mar 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So selenium depends on this but doesn't declare it?

Also, super minor, but the "scope" here is probably redundant.

Copy link
Member Author

@srowen srowen Mar 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but for some reason, the org.w3c class I mentioned doesn't turn up at runtime during the tests. It doesn't happen in a plain vanilla build, but does with the Hadoop 2-style build I ran. The class in question appears to only come from xml-apis.

This looks like the key difference in dependency:tree between the two:

192,193c333
< [INFO] |  |  |  +- xerces:xercesImpl:jar:2.11.0:test
< [INFO] |  |  |  |  \- xml-apis:xml-apis:jar:1.4.01:test
---
> [INFO] |  |  |  +- (xerces:xercesImpl:jar:2.11.0:test - omitted for conflict with 2.9.1)

(Hadoop 2 on the right / >) Looks like something trumps Xerces 2.11 in test scope, with 2.9.1, and that brings in a different xml-apis that doesn't work.

I specified tests in the parent to make sure we don't inadvertently manage non-test deps, and here for clarity.

</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-all</artifactId>
Expand Down
7 changes: 7 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,13 @@
<version>2.42.2</version>
<scope>test</scope>
</dependency>
<!-- Added for selenium only, and should match its dependent version: -->
<dependency>
<groupId>xml-apis</groupId>
<artifactId>xml-apis</artifactId>
<version>1.4.01</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
Expand Down