Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Dec 11, 2024

What changes were proposed in this pull request?

This PR aims to use the latest rouge 4.5.x by removing the upper-bound 3.x (2022-07-29)

Why are the changes needed?

We are using Ruby 3.3 in Apache Spark 4 documentation. So, we don't need to be blocked in the old rouge versions.

ruby-version: '3.3'

You need to have [Ruby 3][ruby] and [Python 3][python] installed. Make sure the `bundle` command is available. If not, install it as follows:

Rouge release notes:

Does this PR introduce any user-facing change?

No behavior change. This only affects documentation.

How was this patch tested?

Manual review. I checked the following.

$ cd docs
$ SKIP_API=1 bundle exec jekyll build

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the DOCS label Dec 11, 2024
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-50549][DOCS] Use rouge 4.5.x by remove the upper bound 3.x [SPARK-50549][DOCS] Use rouge 4.5.x by lifting the upper bound 3.x Dec 11, 2024
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-50549][DOCS] Use rouge 4.5.x by lifting the upper bound 3.x [SPARK-50549][DOCS] Use rouge 4.5.x by removing the upper bound 3.x Dec 11, 2024
@dongjoon-hyun
Copy link
Member Author

cc @HyukjinKwon and @LuciferYang

@HyukjinKwon
Copy link
Member

Merged to master.

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-50549 branch December 12, 2024 00:22
@LuciferYang
Copy link
Contributor

LuciferYang commented Dec 12, 2024

late LGTM
Thanks @dongjoon-hyun

@nchammas
Copy link
Contributor

Last I checked we were still running Ruby 2.7 on CI and in our release infrastructure. Are we sure this change doesn't break on those environments?

To be clear, I agree we should be using Ruby 3 across the board for consistency, but I don't know if we actually did that work yet.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jan 18, 2025

Feel free to update any outdated Ruby 2.7 stuff, @nchammas . You're welcome.

FYI, the Apache Spark community finished Ruby 3.3 validation last September already.

ruby-version: '3.3'

Here is our Ruby 3.3 built page which has been provided officially in GitHub IO infra.

@dongjoon-hyun
Copy link
Member Author

For the record, I really appreciated your various reports and participating including this from your perspective. It leads the Apache Spark community most robust and complete. We need more active participations like yours.

@nchammas
Copy link
Contributor

Oh, that's good to know. https://apache.github.io/ is very nice to have as well!

Thank you for the kind words. Happy to contribute in the small ways that I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants