-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-50549][DOCS] Use rouge 4.5.x by removing the upper bound 3.x
#49149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rouge 4.5.x by remove the upper bound 3.xrouge 4.5.x by lifting the upper bound 3.x
rouge 4.5.x by lifting the upper bound 3.xrouge 4.5.x by removing the upper bound 3.x
|
cc @HyukjinKwon and @LuciferYang |
|
Merged to master. |
|
Thank you, @HyukjinKwon ! |
|
late LGTM |
|
Last I checked we were still running Ruby 2.7 on CI and in our release infrastructure. Are we sure this change doesn't break on those environments? To be clear, I agree we should be using Ruby 3 across the board for consistency, but I don't know if we actually did that work yet. |
|
Feel free to update any outdated Ruby 2.7 stuff, @nchammas . You're welcome. FYI, the Apache Spark community finished
spark/.github/workflows/pages.yml Line 71 in 66dd7dd
Here is our Ruby 3.3 built page which has been provided officially in GitHub IO infra. |
|
For the record, I really appreciated your various reports and participating including this from your perspective. It leads the Apache Spark community most robust and complete. We need more active participations like yours. |
|
Oh, that's good to know. https://apache.github.io/ is very nice to have as well! Thank you for the kind words. Happy to contribute in the small ways that I can. |
What changes were proposed in this pull request?
This PR aims to use the latest
rouge4.5.xby removing the upper-bound3.x(2022-07-29)Why are the changes needed?
We are using
Ruby 3.3in Apache Spark 4 documentation. So, we don't need to be blocked in the oldrougeversions.spark/.github/workflows/pages.yml
Line 71 in 3bb9a72
spark/docs/README.md
Line 33 in b2c8b30
Rougerelease notes:...
Does this PR introduce any user-facing change?
No behavior change. This only affects documentation.
How was this patch tested?
Manual review. I checked the following.
Was this patch authored or co-authored using generative AI tooling?
No.