-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-48139][CONNECT][TESTS] Try stabilising multi-thread tests in CI #48622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, @xupefei .
|
To @xupefei , could you add multiple empty commits on this PR in order to verify your claim?
|
|
An inrelavent test is failing: |
|
Failing on unrelated tests. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
Thank you, @xupefei and @HyukjinKwon .
Yes, the irrelevant failures seem to block the testing. Let's merge this PR.
|
|
||
| // TODO(SPARK-48139): Re-enable `SparkSessionE2ESuite.interrupt tag` | ||
| ignore("interrupt tag") { | ||
| test("interrupt tag") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, unfortunately, it turns out this doesn't help.
- https://github.com/apache/spark/actions/runs/11614520002/job/32342932206
- https://github.com/apache/spark/actions/runs/11605545799/job/32316140558
[info] - interrupt tag *** FAILED *** (1 minute)
[info] Expected exception org.apache.spark.SparkException to be thrown, but java.util.concurrent.TimeoutException was thrown (SparkSessionE2ESuite.scala:250)
|
Sorry but let me revert this because this failed twice a day already in I guess there might be more failures on PR Builders after this PR. |
|
This is reverted via the following. |
|
Sounds good! |
|
@dongjoon-hyun Could you disable |
|
To @xupefei , I believe we should handle them separately. You can apply most of your patch if you exclude these lines. In other words, you should file and use a different JIRA ID for the rest of your contribution because SPARK-48139 is dedicated to this |
|
If you need the rest of patch, please open a new PR (by excluding |
|
It's weird that only the |
|
PR created at #48736. |
What changes were proposed in this pull request?
This PR tries to stabilise flaky tests which involve thread pools. Some tests are failing due to the thread pool having 2 threads instead of 3 or 4.
Why are the changes needed?
To let CI pass.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI will tell.
Was this patch authored or co-authored using generative AI tooling?
No.