[SPARK-49964][BUILD] Remove ws-rs-api package
#48461
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiufung-kwok
changed the title
hiufung-kwok
changed the title
hiufung-kwok
changed the title
Contributor
Author
|
@pan3793 Can you have a look on this, since this is a follow up on SPARK-47118 |
pan3793
reviewed
Oct 15, 2024
hiufung-kwok
force-pushed
the
ft-hf-SPARK-49963-remove-ws-rs-api
branch
from
f4684d6 to
a1976fd
Compare
dongjoon-hyun
changed the title
ws-rs-api package
dongjoon-hyun
approved these changes
Oct 15, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @hiufung-kwok and @pan3793 .
Merged to master for Apache Spark 4.0.0 on February 2025.
dongjoon-hyun
changed the title
ws-rs-api packagews-rs-api package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
javax.ws.rs.ws-rs-apias it's no longer required.Prior discussion can be found on:
Why are the changes needed?
In the past, the codebase used to have a few .scala classes referencing and using the
ws-rs-api, such as b7fdc23#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R624-R627However as the time passed by, all usages of
ws-rs-apiare either got removed / refactored. Hence there is no need to have it import on root POM as now and we can always re-introduce it later, if the usage can be justified again.Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit-test, to make sure the codebase is not impacted by the removal of the dependency.
Was this patch authored or co-authored using generative AI tooling?
No